Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
Clean up duplicate global system table pointer inuefi::helpers
#1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
29f2620
toe2b348e
CompareThese functions now return an `Option`.
Now that `uefi::table` has a pointer to the system table, drop the pointer from`uefi::helpers`.
This functionality is available with `table::system_table_boot` now.
e2b348e
to1970c81
Comparephip1611 approved these changesJun 11, 2024
Merged via the queue intomain with commitJun 11, 2024
ed28e51
15 checks passed
Uh oh!
There was an error while loading.Please reload this page.
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
uefi::table
has a pointer to the system table, drop the pointer fromuefi::helpers
and deprecatehelpers::system_table
.Note this also includes the change from#1175 to make
system_table_boot
/system_table_runtime
returnOption
instead of panicking.Checklist