Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix versions#1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicholasbishop merged 1 commit intorust-osdev:mainfromLightAndLight:fix-versions
Jun 20, 2024
Merged

Fix versions#1187

nicholasbishop merged 1 commit intorust-osdev:mainfromLightAndLight:fix-versions
Jun 20, 2024

Conversation

LightAndLight
Copy link
Contributor

Depends on#1186

uefi 0.28 was released from commit255359a. The tree for that commit
doesn't containResetNotificationProtocol, even though the changelog
says it does.ResetNotificationProtocol was added in commit04be50f,
which was merged in commit0c533bd - both occurring after 0.28 was
released.

This commit fixes those issues, and bumps the unreleased crate versions
so that I can depend on them before this commit is released.

@nicholasbishop
Copy link
Member

Oops, thanks for catching this. I think the only change needed here is fixing the changelogs -- can you amend the commit to remove the other version changes? We don't bump the package versions until we make a new release. You should still be able to use the not-yet-released version locally with[patch.crates-io] andgit orpath dependencies.

@LightAndLight
Copy link
ContributorAuthor

Done

@phip1611
Copy link
Member

thanks!

@phip1611phip1611enabled auto-mergeJune 11, 2024 16:39
@phip1611phip1611 added this pull request to themerge queueJun 11, 2024
@github-merge-queuegithub-merge-queuebot removed this pull request from themerge queue due to a conflict with the base branchJun 11, 2024
@nicholasbishop
Copy link
Member

nicholasbishop commentedJun 14, 2024•
edited
Loading

I pushed a fix for the merge conflict. Seems CI is failing for unrelated reasons on the nightly test:#1205

`uefi` 0.28 was released from commit255359a. The tree for that commitdoesn't contain `ResetNotificationProtocol`, even though the changelogsays it does. `ResetNotificationProtocol` was added in commit04be50f,which was merged in commit `0c533bd` - both occurring after 0.28 wasreleased.
@nicholasbishopnicholasbishop added this pull request to themerge queueJun 20, 2024
Merged via the queue intorust-osdev:main with commite7fe63fJun 20, 2024
12 checks passed
@LightAndLightLightAndLight deleted the fix-versions branchFebruary 25, 2025 22:25
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@LightAndLight@nicholasbishop@phip1611
[8]ページ先頭
©2009-2025 Movatter.jp