NotificationsYou must be signed in to change notification settings
Fork175
Star1.4k

Add #[repr(C)] to AllocateType#1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

LightAndLight wants to merge1 commit intorust-osdev:mainfromLightAndLight:lightandlight/allocatetype-repr-c

Closed

Add #[repr(C)] to AllocateType#1186

LightAndLight wants to merge1 commit intorust-osdev:mainfromLightAndLight:lightandlight/allocatetype-repr-c

Conversation

Copy link

Contributor

LightAndLight commentedJun 7, 2024

EFI_ALLOCATE_TYPE is a C enum (https://uefi.org/specs/UEFI/2.10/07_Services_Boot_Services.html?highlight=efi_allocate_type#efi-boot-services-allocatepages), and it's used in protocols such as the PCI Root Bridge I/O protocol (https://uefi.org/specs/UEFI/2.10/14_Protocols_PCI_Bus_Support.html#efi-pci-root-bridge-io-protocol-allocatebuffer).

Would you like me to add this to the changelog?

Add #[repr(C)] to AllocateType

453bedb

EFI_ALLOCATE_TYPE is a C enum (https://uefi.org/specs/UEFI/2.10/07_Services_Boot_Services.html?highlight=efi_allocate_type#efi-boot-services-allocatepages),and it's used in protocols such as the PCI Root Bridge I/O protocol (https://uefi.org/specs/UEFI/2.10/14_Protocols_PCI_Bus_Support.html#efi-pci-root-bridge-io-protocol-allocatebuffer).

LightAndLight mentioned this pull request

Jun 8, 2024

Fix versions#1187

Merged

Copy link

Member

nicholasbishop commentedJun 8, 2024

I don't think arepr is needed here, because this type is never passed directly to/from the firmware. It's used inBootServices::allocate_pages, which matches on the enum value and converts it to rawtype andaddr values:

uefi-rs/uefi/src/table/boot.rs

Lines 157 to 161 in9cb1d38