Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Note about feature flags for uefi book#1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicholasbishop merged 1 commit intorust-osdev:mainfromstillinbeta:patch-1
May 17, 2024

Conversation

stillinbeta
Copy link
Contributor

@stillinbetastillinbeta commentedMay 14, 2024•
edited
Loading

It took me most of an evening to figure this out, so I thought I'd share it!

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611
Copy link
Member

Sorry for the inconvenience you experienced. Great catch! I left some remarks.

@nicholasbishop I think we should expose all features except forunstable as default feature.

@nicholasbishop
Copy link
Member

@nicholasbishop I think we should expose all features except for unstable as default feature.

Sounds good to me.

@nicholasbishopnicholasbishop added this pull request to themerge queueMay 17, 2024
Merged via the queue intorust-osdev:main with commit75ba438May 17, 2024
@nicholasbishop
Copy link
Member

Merged, thanks for taking the time to document this :)

Filed a followup ticket to set default features.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicholasbishopnicholasbishopnicholasbishop left review comments

@phip1611phip1611phip1611 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@stillinbeta@phip1611@nicholasbishop
[8]ページ先頭
©2009-2025 Movatter.jp