NotificationsYou must be signed in to change notification settings
Fork175
Star1.4k

Remove xtask from MSRV build and update clap#1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

phip1611 merged 2 commits intorust-osdev:mainfromnicholasbishop:bishop-msrv-no-xtask

Apr 22, 2024

Merged

Remove xtask from MSRV build and update clap#1152

phip1611 merged 2 commits intorust-osdev:mainfromnicholasbishop:bishop-msrv-no-xtask

Apr 22, 2024

Conversation

Copy link

Member

nicholasbishop commentedApr 22, 2024

We don't care about the MSRV for xtask, since it's just a dev tool. Also, some of xtask's dependencies (like clap) update MSRV somewhat frequently, so in order to update to the latest version of those deps it's better to not restrict xtask's MSRV.

Also update clap in this PR to test that the change is working as intended.

Checklist

Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
Update the changelog (if necessary)

nicholasbishop added2 commits

April 22, 2024 11:41

ci: Remove xtask from MSRV build

ed039fd

We don't care about the MSRV for xtask, since it's just a dev tool. Also, someof xtask's dependencies (like clap) update MSRV somewhat frequently, so in orderto update to the latest version of those deps it's better to not restrictxtask's MSRV.

Update clap dep

3c22b94