Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
Replacecstr16! with a declarative macro#1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
phip1611 merged 2 commits intorust-osdev:mainfromnicholasbishop:bishop-rework-cstr16-macroApr 21, 2024
Merged
Replacecstr16! with a declarative macro#1145
phip1611 merged 2 commits intorust-osdev:mainfromnicholasbishop:bishop-rework-cstr16-macroApr 21, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Instead of importing the `cstr16` proc macro from `uefi_macros`, add a newdeclarative macro. This makes use of the new `ucs2::ucs2_cstr` declarativemacro, so bump the minimum version of `ucs2` to 0.3.3.
This is replaced by a new `cstr16` declarative macro in the `uefi` crate.
phip1611 approved these changesApr 21, 2024
Nice |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add a new declarative macro that makes use of the
ucs2::ucs2_cstrmacro. Drop the proc macro fromuefi_macros. For users of theuefiAPI there should be no change, just a different implementation behind the scenes.Checklist