Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Minor import/export cleanups#1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

nicholasbishop
Copy link
Member

@nicholasbishopnicholasbishop commentedApr 20, 2024
edited by phip1611
Loading

  • All of the macros from uefi_macros are imported into the uefi crate. Consistently use those imports everywhere, rather than reimporting fromuefi_macros.
  • Consistently import items in theuefi crate withcrate:: instead ofuefi::.
  • Clean up unnecessary uses ofself::.

Should be no change to the public API from this.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

All of the macros from uefi_macros are imported into the ueficrate. Consistently use those imports everywhere, rather than reimporting from`uefi_macros`.
Consistently import items in the `uefi` crate with `crate::` instead of`uefi::`.
Copy link
Member

@phip1611phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@phip1611phip1611 added this pull request to themerge queueApr 21, 2024
Merged via the queue intorust-osdev:main with commitddb81bdApr 21, 2024
@nicholasbishopnicholasbishop deleted the bishop-cleanup-macros-imports branchApril 21, 2024 15:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@phip1611phip1611phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nicholasbishop@phip1611

[8]ページ先頭

©2009-2025 Movatter.jp