Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Nuke uefi services from repository#1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

phip1611
Copy link
Member

@phip1611phip1611 commentedApr 19, 2024•
edited
Loading

Follow-up for#1140 andcloses#1129.

Steps to undraft and Open Questions

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611phip1611 marked this pull request as draftApril 19, 2024 14:58
@phip1611phip1611 marked this pull request as ready for reviewApril 19, 2024 16:32
@phip1611
Copy link
MemberAuthor

The code with the future permutations is originally from you,@nicholasbishop. Any idea on how to continue here? :)

@phip1611phip1611 changed the titleNuke uefi servicesNuke uefi services from repositoryApr 19, 2024
@nicholasbishop
Copy link
Member

I think the updates you made tobuild_feature_permutations look correct, just need to also updateFeature::package_features to addPanicHandler andQemu to theUefi list. Also can dropServicesLogger, since that's justLogger now.

@phip1611
Copy link
MemberAuthor

Thanks, fixed.

@nicholasbishopnicholasbishop added this pull request to themerge queueApr 20, 2024
Merged via the queue intorust-osdev:main with commita307922Apr 20, 2024
@phip1611phip1611 deleted the nuke-uefi-services branchJune 23, 2024 17:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicholasbishopnicholasbishopnicholasbishop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nuke "uefi-services" from repository
2 participants
@phip1611@nicholasbishop
[8]ページ先頭
©2009-2025 Movatter.jp