Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork175
[STALE] Model TCP protocol and implement a client#1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
codyd51 wants to merge4 commits intorust-osdev:mainChoose a base branch fromcodyd51:main
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Hi!
Following up onthis discussion in UEFIRC, a downstream consumer of
uefi-rs
in which I implemented a UEFI TCP client, this PR ports this TCP protocol modelling / client implementation touefi-rs
proper.I made a basic effort to triage some things that were directly modelled with no accoutrements into
uefi-raw
, but I'm sure more can be moved here. It would be nice to place types such asTCPv4Protocol
inuefi-raw
, but this currently contains 'client business logic' and therefore is placed inuefi
.Here are some samples on how the client introduced in this PR can be used to communicate over TCP:
Notes
TCPv4*
types introduced by this PR should be renamed toTcpv4
orTcp4
for consistency across the project?Ip4RouteTable
(and theIp4IcmpType
,Ip4ModeData
, andIp4ConfigData
types introduced by this PR) should perhaps be renamed toIpv4*
for consistency withIpv4Address
.uefi-rs
, or may not be desirable to include as-is. For example, the client currently internally waits up to 10 seconds for a DHCP-assigned IP. You might wish to just include the protocol definitions inuefi-raw
and omit all the business logic, which would be fine and makes sense.Thank you for taking the time to get this PR ready for upstream inclusion!
Steps to Undraft
Checklist