Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Misc] Add ResetNotification protocol. Add Misc to uefi-test-runner.#1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicholasbishop merged 8 commits intorust-osdev:mainfromsky5454:main
Apr 20, 2024

Conversation

sky5454
Copy link
Contributor

I has add the ResetNotification protocol in Misc, and Add Misc with Timestamp and ResetNotification protocol to uefi-test-runner.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See theRewriting History guide for help.
  • Update the changelog (if necessary)

}


pub fn test_reset_notification(image: Handle, bt: &BootServices) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: This only tests to set hook but not that the hook is actually called. Can we fix/add that?

@phip1611
Copy link
Member

phip1611 commentedApr 5, 2024•
edited
Loading

Thanks for the contribution! I left some nits and questions

Please fix the CI, i.e., runcargo fmt

Copy link
Member

@nicholasbishopnicholasbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lgtm, thanks for the PR!

@nicholasbishopnicholasbishop added this pull request to themerge queueApr 20, 2024
Merged via the queue intorust-osdev:main with commit0c533bdApr 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@phip1611phip1611phip1611 left review comments

@nicholasbishopnicholasbishopnicholasbishop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sky5454@phip1611@nicholasbishop
[8]ページ先頭
©2009-2025 Movatter.jp