Commitde79cd7

committed

uefi: Fix lifetimes in device_path TryFrom<&[u8]> impls

The missing lifetime means that the &[u8] buffer could be freed while the&DevicePath still exists, which is UB.

1 parent30d33ec commitde79cd7Copy full SHA for de79cd7

File tree

-3

lines changed

-3

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,12 @@`
`39`	`39`	`> use uefi::table::boot::BootServices;`
`40`	`40`	```
`41`	`41`
	`42`	`+#uefi - 0.30.0 (unreleased)`
	`43`	`+##Changed`
	`44`	+-Breaking:: Fixed a bug in the impls of`TryFrom<&[u8]>` for
	`45`	+`&DevicePathHeader`,`&DevicePathNode` and`&DevicePath` that could lead to
	`46`	`+ memory unsafety. See<https://github.com/rust-osdev/uefi-rs/issues/1281>.`
	`47`	`+`
`42`	`48`	`#uefi - 0.29.0 (2024-07-02)`
`43`	`49`
`44`	`50`	`##Added`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ pub struct DevicePathHeader {`
`119`	`119`	`publength:u16,`
`120`	`120`	`}`
`121`	`121`
`122`		`-impl<'a>TryFrom<&[u8]>for&'aDevicePathHeader{`
	`122`	`+impl<'a>TryFrom<&'a[u8]>for&'aDevicePathHeader{`
`123`	`123`	`typeError =ByteConversionError;`
`124`	`124`
`125`	`125`	`fntry_from(bytes:&[u8]) ->Result<Self,Self::Error>{`
`@@ -265,7 +265,7 @@ impl PartialEq for DevicePathNode {`
`265`	`265`	`}`
`266`	`266`	`}`
`267`	`267`
`268`		`-impl<'a>TryFrom<&[u8]>for&'aDevicePathNode{`
	`268`	`+impl<'a>TryFrom<&'a[u8]>for&'aDevicePathNode{`
`269`	`269`	`typeError =ByteConversionError;`
`270`	`270`
`271`	`271`	`fntry_from(bytes:&[u8]) ->Result<Self,Self::Error>{`
`@@ -516,7 +516,7 @@ impl PartialEq for DevicePath {`
`516`	`516`	`}`
`517`	`517`	`}`
`518`	`518`
`519`		`-impl<'a>TryFrom<&[u8]>for&'aDevicePath{`
	`519`	`+impl<'a>TryFrom<&'a[u8]>for&'aDevicePath{`
`520`	`520`	`typeError =ByteConversionError;`
`521`	`521`
`522`	`522`	`fntry_from(bytes:&[u8]) ->Result<Self,Self::Error>{`

Comments

(0)