- Notifications
You must be signed in to change notification settings - Fork215
implement a new context switch#240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks a lot for implementing this! Unfortunately, I don't have much time right now, but I try my best to review this as soon as possible. |
No worries, take your time! |
57dde98 tocad88acCompareJust rebased onto the latest |
Thanks a lot! I'm really sorry for the delay in reviewing. Given that this changes a critical part of the boot process, I think we should get#232 merged and released first since many people tested that version already. This change would then become |
Sure, sounds good to me! |
Why was this PR closed? Couldn't we just have switched the target branch to |
Given that the delection of the target branch and the closing of this PR happened at the same time I thinl github auto-closed it. |
Oh wow, looks like a race condition on GitHub's side. Normally, it just changes the base branch in this case (and it did so for#282), but apparently it handled the "branch deleted" action first for this PR. |
Ok, restoring the branch allowed me to reopen this PR. I now changed the base branch manually. |
Thanks! |
This pr reimplements the context switch in such a way that we don't need to map any of the bootloader's memory into the kernel's address space (see#239 for more info). This pr also makes the GDT base address configurable instead of identity mapping it into the kernel's address space.
Depends onrust-osdev/x86_64#385
Closes#239