NotificationsYou must be signed in to change notification settings
Fork157
Star889

Add f16, f128#333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

usamoi wants to merge3 commits intorust-num:master

base:master

Choose a base branch

fromusamoi:master

Open

Add f16, f128#333

usamoi wants to merge3 commits intorust-num:masterfromusamoi:master

Conversation

Copy link

usamoi commentedAug 26, 2024•
edited
Loading

integer_decode is implemented forf128 by truncating the radix to its 64 most significant bits. SeeFloat::integer_decode cannot be implemented for quadruple precision floating types. #98.
Because of precision limitations,f128 tests underno_std andlibm fail.

cuviper reviewed

Aug 26, 2024

View reviewed changes

src/lib.rs Outdated

Comment on lines 20 to 21

		#![cfg_attr(feature ="f16", feature(f16))]
		#![cfg_attr(feature ="f128", feature(f128))]

Copy link

Member

cuviperAug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not keen on maintaining for unstable features in this crate, so we're probably going to be blocked here until the language and standard library stabilize these new floats.

At that point, I think we'll probably want to have detection in the build script to enable it automatically, and Cargo features can force that on -- like we used to forhas_i128.