- Notifications
You must be signed in to change notification settings - Fork157
Makefloat::Float::integer_decode DRY#328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
mtilda wants to merge12 commits intorust-num:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
`float::Float::integer_decode`
141f91e to6d30ca6Compareinteger_decode_f32 andinteger_decode_f64 with new macrointeger_decode!float::Float::integer_decode DRY… new macro `integer_decode\!`
3971e1c to0a0a8e5CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Blocked by#327
Motivation
The trait method
float::Float::integer_decodeinvokes one of the functionsinteger_decode_f32orinteger_decode_f64depending on the implementation. These functions share a lot of code, so I would like to refactor them to use the same underlying source.Considerations
float::Float::integer_decode#327.Status
This is a work in progress, as indicated by the fact that it is a Draft PR. Comments and suggestions are welcome, but not expected.