Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Basic support for axis simplification and arbitrary order in iterators#979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bluss wants to merge8 commits intomaster
base:master
Choose a base branch
Loading
fromiterator-order

Conversation

bluss
Copy link
Member

@blussbluss commentedApr 11, 2021
edited
Loading

  • In some cases we can modify the iterator without changing produced element order - for example changing shape [10, 1] to shape [1, 10]
  • In some cases we can merge axes without changing visible element order. Iterating shape [2, 5, 3] as if it is shape [1, 1, 30], if the strides allow
  • In some cases we want to use arbitrary order (here it becomes the in-memory order)
  • In some cases we don't want to change anything (standard order indexed iterator)

Current state of the PR: groundwork, not actually used in any iterator

@blussblussforce-pushed theiterator-order branch 4 times, most recently frome5224a5 to49bf28aCompareApril 12, 2021 20:42
@blussblussforce-pushed theiterator-order branch 3 times, most recently from08068a8 to2d6bcdeCompareMay 5, 2021 16:00
@blussbluss marked this pull request as ready for reviewMay 5, 2021 16:16
@blussbluss modified the milestones:0.15.2,0.15.3May 10, 2021
@blussbluss modified the milestones:0.15.3,0.16.0Jun 5, 2021
These `pub` here actually predate the pub(crate) feature, and theyshould just be `pub(crate)` or lower since they are unreachable outsidethe crate.
This is special for arrays of shape 1 x n or n x 1; add iterator anditerator sum (fold) benchmarks.
Implement axis merging - this preserves order of elements in theiteration but might simplify iteration. For example, in a contiguousmatrix, a shape like [3, 4] can be merged into [1, 12].Also allow arbitrary order optimization - we then try to iterate inmemory order by sorting all axes, currently.
This one complains about if let Some(_) = option; which I still think isjust as fine as if option.is_some(); `if let` is a nice Rust featurethat works the same way on all enums, no reason to preferoption-specific methods like `is_some`.
@blussbluss modified the milestones:0.16.0,0.17.0Apr 6, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jturner314jturner314jturner314 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

2 participants
@bluss@jturner314

[8]ページ先頭

©2009-2025 Movatter.jp