- Notifications
You must be signed in to change notification settings - Fork338
Basic support for axis simplification and arbitrary order in iterators#979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bluss wants to merge8 commits intomasterChoose a base branch fromiterator-order
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
e5224a5
to49bf28a
Compare08068a8
to2d6bcde
CompareThese `pub` here actually predate the pub(crate) feature, and theyshould just be `pub(crate)` or lower since they are unreachable outsidethe crate.
This is special for arrays of shape 1 x n or n x 1; add iterator anditerator sum (fold) benchmarks.
Implement axis merging - this preserves order of elements in theiteration but might simplify iteration. For example, in a contiguousmatrix, a shape like [3, 4] can be merged into [1, 12].Also allow arbitrary order optimization - we then try to iterate inmemory order by sorting all axes, currently.
This one complains about if let Some(_) = option; which I still think isjust as fine as if option.is_some(); `if let` is a nice Rust featurethat works the same way on all enums, no reason to preferoption-specific methods like `is_some`.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Current state of the PR: groundwork, not actually used in any iterator