- Notifications
You must be signed in to change notification settings - Fork338
Introduce an ArrayLike trait#1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
akern40 wants to merge4 commits intorust-ndarray:masterChoose a base branch fromakern40:arraylike
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is one of two PRs I'm working on that start to "traitify" ndarray. This trait is like the
Ndarray
trait suggested by@bluss in#339, but is slightly broader: it's meant to encapsulate not just actualndarray
types, but anything that could actlike a multidimensional array. This includes Vecs, slices, arrays, and (critically) scalars that implementScalarOperand
.The motivation for me was trying to design a set of methods expanded numerical methods, addressing#1462 (and others). My goal was to have these methods
num_traits
traits, i.e.,abs
forT: Signed
.I was able to accomplish 1-3 with existing infrastructure, but you can see in#1462 that I was struggling with (4). This trait would allow me to accomplish all of these tasks.
Feedback is greatly welcome. Keep an eye out for two more upcoming PRs:
ArrayLike
, to close #14632Ndarray
trait, following the design ofNdArray
trait #339Note: This PR uses#1440 so should be merged after that.