- Notifications
You must be signed in to change notification settings - Fork338
Use PR check instead of Merge Queue, and check rustdoc#1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bluss commentedAug 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'm wondering what you think@adamreichold - if you have time. Cross tests are now a lot faster (I reduced the size of matrices tested by a good factor.), so speed should not be a problem. |
Apologies for sending a question and then merging, but I'm moving quickly with these changes (when I actually do something). I still want to hear thoughts, even if this is already merged, it's easy to update. |
005be01 intomasterUh oh!
There was an error while loading.Please reload this page.
We've used Merge Queue well but now I want to try going back to using PR check instead.
The reason is that PR check allows maintainers to choose to integrate PRs using either squash, rebase or merge.
IMO squash should be preferred when the PR is one coherent change. Merge commit or rebase should be used when the PR is well split into different commits.
I find that we want to have both options available, and that's not possible with the merge queue.