- Notifications
You must be signed in to change notification settings - Fork338
Give MathCell arithmetic ops implementations when MathCell is left value#1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
SparrowLii wants to merge1 commit intorust-ndarray:masterChoose a base branch fromSparrowLii:mathcell_ops
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
bluss commentedMay 21, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We don't implement ArrayViewMut + x (only ArrayViewMut += x), and this should be the same way IMO. I.e we want the |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Update#969
Four functions are implemented for
ArrayView<MathCell, _>
in impl_methods.rs:zip_cell_with
,zip_cell_with_elem
,zip_cell_with_same_shape
,zip_cell_with_by_rows
.Operator overloading is implemented in impl_ops.rs for the following situations:
ArrayView<MathCell, _> binary_op &ArrayBase
ArrayView<MathCell, _> binary_op Scalar
ArrayView<MathCell, _> assign_op &ArrayBase
ArrayView<MathCell, _> assign_op Scalar
The unresolved problems are:
Currently
MathCell
can only be left value. The main reason are:(1) Conflicts occur when compiling
MathCell<A> op MathCell<B>
(2) Rust's orphan rules. We can't write code like this:
impl<T> Add<MathCell<T>> for T
. This will causeE0210 errorThe value in
MathCell
must beCopy
This is because the value in MathCell needs to be retrieved using the
get()
method. We cannot get&T
from&MathCell<T>
unless we create a new structureMathRefCell(RefCell<T>)