- Notifications
You must be signed in to change notification settings - Fork74
Queueing async and sync functions on the main thread#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
quickdudley wants to merge2 commits intorust-native-ui:trunkChoose a base branch fromquickdudley:55-async-queue-main
base:trunk
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to#55
Two new methods in
UI
:async_context
creates a token (iui::concurrent::Context
) which can serve as evidence thatUI::init()
has run successfully; this token isSend
spawn
schedules an async function or future on the main thread. Since it's a method inUI
it can only be run in the main thread. It returns control to the main loop when it blocks and queues itself again when it's ready again.Two methods in
concurrent::Context
queue_main
behaves likeUI::queue_main
in that it schedules a closure or function to run on the main thread. UnlikeUI::queue_main
it can be run in other threads but requires the closure to beSend
.spawn
behaves likeUI::spawn
but can be run from other threads; requires the future to beSend
Using
UI::spawn
and an async channel such as provided bytokio::sync::mpsc
we can wait for things to happen on other threads without busy waiting or blocking other events and then update our widgets accordingly.