Should thestd::error::Error::source() method be implemented to provide thesource error for this?

@djc Thanks for asking, but I'm not sure, actually. I noticed thatSettingPermissions is usingio::Error here, so I followed the same pattern. Do you have any suggestions?

Should thestd::error::Error::source() method be implemented to yield thesource error for this?

According to the thiserrordocumentation, it states:

The Error trait’s source() method is implemented to return whichever field has a #[source] attribute or is named source, if any. This is for identifying the underlying lower level error that caused your error.

The #[from] attribute always implies that the same field is #[source], so you don’t ever need to specify both attributes.

Any error type that implements std::error::Error or dereferences to dyn std::error::Error will work as a source.

#[derive(Error, Debug)]pub struct MyError {    msg: String,    #[source]  // optional if field name is `source`    source: anyhow::Error,}

Is it still necessary to implement the std::error::Error::source() method?

Sure, but your PR does not add any#[source] attribute, right?

Sure, but your PR doesn't add any#[source] attribute, right?

This PR didn't add#[source] because this macro is optional if the field name issource, as the documentation mentions.

So it should implementedstd::error::Error::source() method bythiserror crate.

Sure, but your PR doesn't add any#[source] attribute, right?

This PR didn't add#[source] because this macro is optional if the field name issource, as the documentation mentions.

So it should implementedstd::error::Error::source() method bythiserror crate.

Ahh, okay, thanks.

@Binlogo just squash your commits please -- the second commit really belongs with the first one.

@djc Squashed. Thanks for the review.