- Notifications
You must be signed in to change notification settings - Fork933
Implement remove_nested_blocks option#6489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
karolzwolak wants to merge4 commits intorust-lang:masterChoose a base branch fromkarolzwolak:remove_nested_blocks
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8393df5
toeaab0de
Compareinner_label, | ||
true, | ||
context, | ||
shape, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure if this is correct, it does seem to work, but I'm confused what the shape is even for.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Implements new feature that removes nested blocks#5616.
The feature is similar to
remove_nested_parens
. Blocks with any sort of comments or attributes,unsafe
andconst
blocks will not be removed. This however will not remove all nested blocks, instead it will leave the innermost block (similar toremove_nested_parens
). That behavior differs from suggested in the issue, and I'm not sure which one is better.I'm not fully satisfied with my implementation, so any suggestions are appreciated.
I also was not sure what do do if nested blocks are of different kind (nested
const
and/orunsafe
blocks), so I decided to only remove 'naked' blocks, and just never removeconst
andunsafe
blocks. There is some merit to removingunsafe
orconst
blocks when only blocks of one kind are nested, but for the sake of consistency I decided to not do that. An example of such problematic situation:As I said, for now both
mixed
, andone_kind
functions would only remove the blocks annotated by comments.I'm open for suggestions regarding the behavior, since the feature in the original issue was very loosely defined (also blocks are more tricky than parentheses)