- Notifications
You must be signed in to change notification settings - Fork80
Fix UB in 128 bit cttz/ctlz intrinsics#672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
FractalFir wants to merge1 commit intorust-lang:masterChoose a base branch fromFractalFir:ctlz_128
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+102 −44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks for sending this PR. How does the generated code compare to the fix made inthis PR? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#604.
This PR changes a few things.
First of all, it enables UB checks for tests in debug mode: This should allow us to catch any regressions.
Second, I extracted the common implementation of the "safe"
ctlz
/cttz
intrinsics into a separate function.This makes handling the 128 bit edge case a bit easier, and allows us to use those intrinsics.
The third change modifies the 128 bit
ctlz
/cttz
emulation to use the "safe" version of the 64 bit intrinsic, instead of calling the GCC built-in directly.Effectively, this turns a piece of IR like this:
Into a piece of code like this:
This solution is not the prettiest(maybe a few less branches could be used?), but it is UB-free, and relatively easy to implement.