Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

support tile builtins#623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
g4titanx wants to merge3 commits intorust-lang:master
base:master
Choose a base branch
Loading
fromg4titanx:tile-intrisics

Conversation

g4titanx
Copy link
Contributor

this prfixes#563

Copy link
Contributor

@antoyoantoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please also enable the tile tests by adressingthis comment.

@g4titanx
Copy link
ContributorAuthor

@antoyo i need some clarity on impl. the tile intrinsics. currently, I see a few possible approaches:

  1. Usingget_target_builtin_function, but this fails with "Cannot find target builtin" errors since these don't have GCC builtin equivalents.

  2. Creating custom functions with inline assembly, something like:

"llvm.x86.ldtilecfg" =>{let name ="__rustc_tile_ldtilecfg";let func = cx.context.new_function(None,FunctionType::Internal,        cx.type_void(),&[/* params */],        name,false,);}

@antoyo
Copy link
Contributor

Yeah,get_target_builtin_function won't work.

Perhaps your solution#2 would be the simplest (if that works). You could add the attribute AlwaysInline to make sure it's efficient.

Otherwise, I see another solution involving changing thetype Function to anenum that would either take aFunction or inline asm, but that might be a lot of work, so I would go with#2 if that works.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@antoyoantoyoantoyo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the tile intrinsics
2 participants
@g4titanx@antoyo

[8]ページ先頭

©2009-2025 Movatter.jp