Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement int extension#552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sapir wants to merge2 commits intorust-lang:master
base:master
Choose a base branch
Loading
fromsapir:implement-int-extension

Conversation

sapir
Copy link
Contributor

I tried to fix the FIXME inzext. Would this be acceptable?

Also, how should I add tests?

@sapirsapirforce-pushed theimplement-int-extension branch fromcc2bbb8 to3f1304aCompareAugust 5, 2024 21:32
@antoyo
Copy link
Contributor

For the test, you can either add it tothis file or you can create another file in that directory.

@antoyo
Copy link
Contributor

Did you want to add a test or would you want to merge this as is?

@sapir
Copy link
ContributorAuthor

I did try to add a test and found that the test passes either way, so maybe I should change the PR to just add the test instead of changing the code?

@antoyo
Copy link
Contributor

You mean, to make sure the test fails without the implementation of int extension?
If so, yes, you can push a test, remove the implementation to make sure the test fails and push back the implementation.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sapir@antoyo

[8]ページ先頭

©2009-2025 Movatter.jp