- Notifications
You must be signed in to change notification settings - Fork80
Implement int extension#552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
cc2bbb8
to3f1304a
CompareFor the test, you can either add it tothis file or you can create another file in that directory. |
Did you want to add a test or would you want to merge this as is? |
I did try to add a test and found that the test passes either way, so maybe I should change the PR to just add the test instead of changing the code? |
You mean, to make sure the test fails without the implementation of int extension? |
I tried to fix the FIXME in
zext
. Would this be acceptable?Also, how should I add tests?