- Notifications
You must be signed in to change notification settings - Fork80
Implement prefetch data intrinsics#420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Do you know what kind of tests there is for this in the LLVM codegen? |
The codegen tests are probably the most thorough, but they are LLVM specific. However, according to the FileCheck documentation, it doesn't do much that can't be done with grep. At a minimum though, I think we should check that the compiler can encounter the function without panicking. |
I would be OK with such a test. You can add itin this directory. |
Is this still a draft or should I review this PR? |
Oh, sorry, I didn't notice you marked this PR as ready for review (please ping me if I don't answer for some time: I can easily miss some things). There are some conflicts to fix. |
Fixes#414
It should probably have tests that should fail before the changes. What kind of test should I add?
I edited the builtin list in context.rs, and that might create a conflict when syncing with the rust repository.