Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Avoid \u{1} prefix when the user overrode item names#3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
bjorn3 wants to merge1 commit intorust-lang:main
base:main
Choose a base branch
Loading
frombjorn3:better_link_name_handling

Conversation

bjorn3
Copy link
Member

\u{1} is an LLVM specific extension which other rustc codegen backends do not support.

Fixes#2935

skewballfox reacted with hooray emojiretorted reacted with rocket emoji
@bjorn3bjorn3 changed the titleAvoid \u{1} prefix when the user overrode symbol namesAvoid \u{1} prefix when the user overrode item namesMar 20, 2025
\u{1} is an LLVM specific extension which other rustc codegen backendsdo not support.
@bjorn3bjorn3force-pushed thebetter_link_name_handling branch fromfc322e0 to50eb27fCompareMarch 20, 2025 15:16
@bjorn3
Copy link
MemberAuthor

Why does the Publish on crates.io workflow get invoked even though this PR hasn't been merged? It gives me a failure notification.https://github.com/rust-lang/rust-bindgen/actions/runs/13972867609

@bjorn3
Copy link
MemberAuthor

Right, for Mach-O all symbols get mangled to add an_ prefix. Is there a way in libclang to get the symbol name before the object file format specific mangling but after C++ mangling? (aka the input LLVM expects then not using\u{1})

@emilio
Copy link
Contributor

Why does the Publish on crates.io workflow get invoked even though this PR hasn't been merged? It gives me a failure notification.https://github.com/rust-lang/rust-bindgen/actions/runs/13972867609

cc@pvdrz . My understanding is that it's not supposed to run, but maybe these fields are anor rather than anand:

on:
workflow_run:
workflows:
-Release
types:
-completed

@bjorn3bjorn3 marked this pull request as draftApril 4, 2025 15:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid using \u{1} prefixes in symbol names where possible
2 participants
@bjorn3@emilio
[8]ページ先頭
©2009-2025 Movatter.jp