- Notifications
You must be signed in to change notification settings - Fork13.9k
cmse: add test forasync andconst functions#148536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
folkertdev wants to merge1 commit intorust-lang:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+23 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
async functions are disallowed (because `-> impl Trait` is not supported). `const` entry functions are allowed, nonsecure-call functions must be function pointers, which cannot be evaluated during constant evaluation.
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
F-cmse_nonsecure_entry`#![feature(cmse_nonsecure_entry)]` S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue:#81391
tracking issue:#75835
Some additional tests that seemed useful while working on the RFC text.
asyncfunctions are disallowed (because-> impl Traitis not supported).constentry functions are allowed,nonsecure-calldoes not make sense, because this abi can only be used on function pointers, which cannot be evaluated during constant evaluation.The async test is in the
c-variadic.rsfile because it has the minicore-compatible machinery for defining an async function. Splitting that logic out (likeminisimd.rs) turns out to be complicated because the async stuff relies on types defined by minicore.r?@davidtwco