- Notifications
You must be signed in to change notification settings - Fork13.5k
Remove theCoroutineWitness type#144157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
compiler-errors wants to merge4 commits intorust-lang:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+302 −649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@bors2 try@rust-timer queue (and crater when it's ready) |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rust-borsbot added a commit that referenced this pull requestJul 18, 2025
Remove the `CoroutineWitness` typeIt's no longer needed, since it just always the `Coroutine` that it's contained within.This PR reworks a bit of obligation stalling logic and dtorck constraint behavior, but otherwise it's pretty straightforward.r? `@lcnr` or reassign (e.g. to oli, who probably would also be down to review)
The job Click to see the possible cause of the failure (guessed by this bot) |
| @@ -905,6 +905,7 @@ pub trait PrettyPrinter<'tcx>: Printer<'tcx> + fmt::Write { | |||
| } | |||
| }else{ | |||
| p!(print_def_path(did, args)); | |||
| // TODO: Restore witness types? | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll probably leave these out. Otherwise we could have query cycles here.
| }else{ | ||
| // TODO: We could still recurse into upvars and the resume here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is definitely a FIXME for later. I don't think this has any side effect.
Queued0282016 with parent8f08b3a, futurecomparison URL. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
PG-exploit-mitigationsProject group: Exploit mitigations S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perfStatus: Waiting on a perf run to be completed. T-clippyRelevant to the Clippy team. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's no longer needed, since it just always the
Coroutinethat it's contained within.This PR reworks a bit of obligation stalling logic and dtorck constraint behavior, but otherwise it's pretty straightforward.
r?@lcnr or reassign (e.g. to oli, who probably would also be down to review)