Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix-Ctarget-features getting ignored aftercrt-static#144143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Gelbpunkt wants to merge2 commits intorust-lang:master
base:master
Choose a base branch
Loading
fromGelbpunkt:target-features-crt-static

Conversation

Gelbpunkt
Copy link
Contributor

@GelbpunktGelbpunkt commentedJul 18, 2025•
edited
Loading

The current behaviour introduced by commita50a3b8 would discard any target features specified aftercrt-static (the only member ofRUSTC_SPECIFIC_FEATURES). This is because it returned instead of continuing processing the next feature.

I wasn't entirely sure how the regression test should look like, but this one should do. If anyone has some suggestions, I'm happy to learn, it's my first test :)

I've confirmed that the test fails without the fix onpowerpc64le-unknown-linux-musl andx86_64-unknown-linux-gnu.

cc@RalfJung

The current behaviour introduced by commita50a3b8 would discard anytarget features specified after crt-static (the only member ofRUSTC_SPECIFIC_FEATURES). This is because it returned instead ofcontinuing processing the next flag.Signed-off-by: Jens Reidel <adrian@travitia.xyz>
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
@rustbot
Copy link
Collaborator

r?@compiler-errors

rustbot has assigned@compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

User? to explicitly pick a reviewer

@rustbotrustbot added the S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelJul 18, 2025
@rustbot
Copy link
Collaborator

Some changes occurred in compiler/rustc_codegen_ssa

cc@WaffleLapkin

@rustbotrustbot added the T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. labelJul 18, 2025
@GelbpunktGelbpunkt changed the titleFix-Ctarget-features getting ignored aftercrt-staticFix-Ctarget-features getting ignored aftercrt-staticJul 18, 2025
@Gelbpunkt
Copy link
ContributorAuthor

This should probably also be backported to 1.89.

@workingjubileeworkingjubilee added the beta-nominatedNominated for backporting to the compiler in the beta channel. labelJul 18, 2025
@apiraino
Copy link
Contributor

apiraino commentedJul 18, 2025•
edited
Loading

Regression introduced in#140920

@tgross35
Copy link
Contributor

@Noratrieb
Copy link
Member

@Gelbpunkt can you open an issue for this? We usually don't require issues for bug fixes but we use them for tracking backports, so it would be useful here.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errorscompiler-errors

Labels
beta-nominatedNominated for backporting to the compiler in the beta channel.S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@Gelbpunkt@rustbot@apiraino@tgross35@Noratrieb@compiler-errors@workingjubilee
[8]ページ先頭
©2009-2025 Movatter.jp