Next step will be to add these annotations in the files where either the output is different based on the codegen (likeasm tests) or that are known to fail in the GCC backend.

cc@oli-obk @antoyo
r?@Kobzol

Add newignore-backends tests annotations

c479671

rustbot assignedKobzol

Jul 18, 2025

rustbot added A-compiletest

Area: The compiletest test runner

A-rustc-dev-guide

Area: rustc-dev-guide

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels

Jul 18, 2025

Copy link

Collaborator

rustbot commentedJul 18, 2025

Some changes occurred in src/tools/compiletest

cc@jieyouxu

The rustc-dev-guide subtree was changed. If this PRonly touches the dev guide consider submitting a PR directly torust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc@BoxyUwU,@jieyouxu,@Kobzol,@tshepang

Copy link

Member

bjorn3 commentedJul 18, 2025

For asm tests I think adding//@ needs-backends: llvm to every test is a bad idea. Rather I think gating the entire asm test suite behind the LLVM backend inside compiletest itself or moving the test assertions to backend specific files would be better options. For ui tests these test annotations do make sense to me however.

Copy link

MemberAuthor

GuillaumeGomez commentedJul 18, 2025

I didn't look how many tests were there but you're right, would make more sense to just ignore these tests completely if it's not llvm backend. I think I'll rename the folder to better express it (asm ->asm-llvm). It could also allow to add a more generic check for this folder by directly checking if the backend name matches the current one, allowing to add asm tests for cranelift and gcc backends.

Kobzol reviewed

Jul 18, 2025

View reviewed changes

Copy link

Member

Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

CC@jieyouxu

src/tools/compiletest/src/directives.rs Outdated

		{
		returnIgnoreDecision::Ignore{
		reason:format!(
		"{} backend is not part of backends",

Copy link

Member

KobzolJul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	"{} backend is not part of backends",
	"{} backend is not part ofrequiredbackends",

Copy link

Member

jieyouxu commentedJul 18, 2025

For asm tests I think adding//@ needs-backends: llvm to every test is a bad idea. Rather I think gating the entire asm test suite behind the LLVM backend inside compiletest itself or moving the test assertions to backend specific files would be better options. For ui tests these test annotations do make sense to me however.

Yeah, I think this is for the best.