Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork14.5k
Comments
Decouple "reporting in deps" fromFutureIncompatibilityReason#141936
Merged
bors merged 1 commit intorust-lang:masterfromJun 3, 2025
Merged
Decouple "reporting in deps" fromFutureIncompatibilityReason#141936bors merged 1 commit intorust-lang:masterfrom
FutureIncompatibilityReason#141936bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
rustbot commentedJun 2, 2025
Comment on lines 410 to 413
| /// After some period of time, lints with this variant can be turned into | ||
| /// hard errors (and the lint removed). Preferably when there is some | ||
| /// confidence that the number of impacted projects is very small (few | ||
| /// should have a broken dependency in their dependency tree). |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this comment should be preserved, potentially mentioningreport_in_deps
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I tried to preserve the meaning of the comment, can you check if I missed something?
e04270f to9b7da4dCompareContributor
oli-obk commentedJun 3, 2025
@bors r+ rollup |
Collaborator
bors commentedJun 3, 2025
bors added a commit that referenced this pull requestJun 3, 2025
Rollup of 9 pull requestsSuccessful merges: -#141554 (Improve documentation for codegen options) -#141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…) -#141843 (Add `visit_id` to ast `Visitor`) -#141881 (Subtree update of `rust-analyzer`) -#141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id) -#141921 (Disable f64 minimum/maximum tests for arm 32) -#141930 (Enable triagebot `[concern]` functionality) -#141936 (Decouple "reporting in deps" from `FutureIncompatibilityReason`) -#141949 (move `test-float-parse` tool into `src/tools` dir)r? `@ghost``@rustbot` modify labels: rollup
7100905 intorust-lang:master 10 checks passed
Uh oh!
There was an error while loading.Please reload this page.
rust-timer added a commit that referenced this pull requestJun 3, 2025
Rollup merge of#141936 - WaffleLapkin:report-in-deps-decoupling, r=oli-obkDecouple "reporting in deps" from `FutureIncompatibilityReason`The reason should just be it -- the reason. It never felt right to me that it was also responsible for whatever we include the warning in cargo's reports.It gets especially unruly if you want to add non-`FutureReleaseError*` warnings which are included in the reports.I just added a field to `FutureIncompatibleInfo` to control whatever the diagnostic is included in the cargo's reports.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull requestJun 9, 2025
Rollup of 9 pull requestsSuccessful merges: -rust-lang/rust#141554 (Improve documentation for codegen options) -rust-lang/rust#141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…) -rust-lang/rust#141843 (Add `visit_id` to ast `Visitor`) -rust-lang/rust#141881 (Subtree update of `rust-analyzer`) -rust-lang/rust#141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id) -rust-lang/rust#141921 (Disable f64 minimum/maximum tests for arm 32) -rust-lang/rust#141930 (Enable triagebot `[concern]` functionality) -rust-lang/rust#141936 (Decouple "reporting in deps" from `FutureIncompatibilityReason`) -rust-lang/rust#141949 (move `test-float-parse` tool into `src/tools` dir)r? `@ghost``@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull requestJun 15, 2025
… r=oli-obk,traviscrossReport never type lints in dependenciesThis PR marks never type lints (`never_type_fallback_flowing_into_unsafe` & `dependency_on_unit_never_type_fallback`) to be included in cargo's reports / to be emitted when they happen in dependencies.This PR is based onrust-lang#141936r? oli-obk
fmease added a commit to fmease/rust that referenced this pull requestJun 15, 2025
… r=oli-obk,traviscrossReport never type lints in dependenciesThis PR marks never type lints (`never_type_fallback_flowing_into_unsafe` & `dependency_on_unit_never_type_fallback`) to be included in cargo's reports / to be emitted when they happen in dependencies.This PR is based onrust-lang#141936r? oli-obk
rust-timer added a commit that referenced this pull requestJun 16, 2025
Rollup merge of#141937 - WaffleLapkin:never-report-in-deps, r=oli-obk,traviscrossReport never type lints in dependenciesThis PR marks never type lints (`never_type_fallback_flowing_into_unsafe` & `dependency_on_unit_never_type_fallback`) to be included in cargo's reports / to be emitted when they happen in dependencies.This PR is based on#141936r? oli-obk
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull requestJun 17, 2025
…iaskrgrRollup of 9 pull requestsSuccessful merges: -rust-lang#141554 (Improve documentation for codegen options) -rust-lang#141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…) -rust-lang#141843 (Add `visit_id` to ast `Visitor`) -rust-lang#141881 (Subtree update of `rust-analyzer`) -rust-lang#141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id) -rust-lang#141921 (Disable f64 minimum/maximum tests for arm 32) -rust-lang#141930 (Enable triagebot `[concern]` functionality) -rust-lang#141936 (Decouple "reporting in deps" from `FutureIncompatibilityReason`) -rust-lang#141949 (move `test-float-parse` tool into `src/tools` dir)r? `@ghost``@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason should just be it -- the reason. It never felt right to me that it was also responsible for whatever we include the warning in cargo's reports.
It gets especially unruly if you want to add non-
FutureReleaseError*warnings which are included in the reports.I just added a field to
FutureIncompatibleInfoto control whatever the diagnostic is included in the cargo's reports.