- Notifications
You must be signed in to change notification settings - Fork14.1k
only return nested goals forCertainty::Yes#140402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
compiler-errors commentedApr 28, 2025
army |
Member
compiler-errors commentedApr 28, 2025
@bors r+ rollup |
Collaborator
bors commentedApr 28, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull requestApr 28, 2025
…r=compiler-errorsonly return nested goals for `Certainty::Yes`Ambiguous `NormalizesTo` goals can otherwise repeatedly add the same nested goals to the parent.r? `@compiler-errors`
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 28, 2025
…entonRollup of 9 pull requestsSuccessful merges: -rust-lang#139308 (add autodiff inline) -rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) -rust-lang#140374 (Resolve instance for SymFn in global/naked asm) -rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) -rust-lang#140394 (Make bootstrap git tests more self-contained) -rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) -rust-lang#140402 (only return nested goals for `Certainty::Yes`)r? `@ghost``@rustbot` modify labels: rollup
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull requestApr 28, 2025
…r=compiler-errorsonly return nested goals for `Certainty::Yes`Ambiguous `NormalizesTo` goals can otherwise repeatedly add the same nested goals to the parent.r? ``@compiler-errors``
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 28, 2025
…entonRollup of 10 pull requestsSuccessful merges: -rust-lang#139308 (add autodiff inline) -rust-lang#139656 (Stabilize `slice_as_chunks` library feature) -rust-lang#140022 (allow deref patterns to move out of boxes) -rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) -rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) -rust-lang#140394 (Make bootstrap git tests more self-contained) -rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) -rust-lang#140402 (only return nested goals for `Certainty::Yes`)Failed merges: -rust-lang#139765 ([beta] Delay `hash_extract_if` stabilization from 1.87 to 1.88)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 29, 2025
…entonRollup of 10 pull requestsSuccessful merges: -rust-lang#139308 (add autodiff inline) -rust-lang#139656 (Stabilize `slice_as_chunks` library feature) -rust-lang#140022 (allow deref patterns to move out of boxes) -rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) -rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) -rust-lang#140394 (Make bootstrap git tests more self-contained) -rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) -rust-lang#140402 (only return nested goals for `Certainty::Yes`)r? `@ghost``@rustbot` modify labels: rollup
bf37847 intorust-lang:master 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestApr 29, 2025
Rollup merge ofrust-lang#140402 - lcnr:normalizes-to-certainty-yes, r=compiler-errorsonly return nested goals for `Certainty::Yes`Ambiguous `NormalizesTo` goals can otherwise repeatedly add the same nested goals to the parent.r? ```@compiler-errors```
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ambiguous
NormalizesTogoals can otherwise repeatedly add the same nested goals to the parent.r?@compiler-errors