- Notifications
You must be signed in to change notification settings - Fork14.1k
Rollup of 7 pull requests#140329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Rollup of 7 pull requests#140329
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This commit updates the vendored `wasm-component-ld` binary to 0.5.13which includes some various bug fixes and new feature updates forupcoming component model features coming down the pike. Not expected tobreak any existing workflows, just a normal update.
Note that `NonZero` support is not wired up, as the author encounteredbugs while attempting this. A future commit will wire up `NonZero`support.
… r=jdonszelmann,traviscrossImplement a lint for implicit autoref of raw pointer dereference - take 2*[t-lang nomination comment](rust-lang#123239 (comment)This PR aims at implementing a lint for implicit autoref of raw pointer dereference, it is based onrust-lang#103735 with suggestion and improvements fromrust-lang#103735 (comment).The goal is to catch cases like this, where the user probably doesn't realise it just created a reference.```rustpub struct Test { data: [u8],}pub fn test_len(t: *const Test) -> usize { unsafe { (*t).data.len() } // this calls <[T]>::len(&self)}```Sincerust-lang#103735 already went 2 times through T-lang, where they T-lang ended-up asking for a more restricted version (which is what this PR does), I would prefer this PR to be reviewed first before re-nominating it for T-lang.----Compared to the PR it is as based on, this PR adds 3 restrictions on the outer most expression, which must either be: 1. A deref followed by any non-deref place projection (that intermediate deref will typically be auto-inserted) 2. A method call annotated with `#[rustc_no_implicit_refs]`. 3. A deref followed by a `addr_of!` or `addr_of_mut!`. See bottom of post for details.There are several points that are not 100% clear to me when implementing the modifications: - ~~"4. Any number of automatically inserted deref/derefmut calls." I as never able to trigger this. Am I missing something?~~ Fixed - Are "index" and "field" enough?----cc ``@JakobDegen`` ``@WaffleLapkin``r? ``@RalfJung``
…o, r=jswrenntransmutability: Support char, NonZeroXxxNote that `NonZero` support is not wired up, as the author encounteredbugs while attempting this. A future commit will wire up `NonZero`support.r? ``@jswrenn``
…-ld, r=jieyouxuUpdate wasm-component-ld to 0.5.13This commit updates the vendored `wasm-component-ld` binary to 0.5.13 which includes some various bug fixes and new feature updates for upcoming component model features coming down the pike. Not expected to break any existing workflows, just a normal update.
…lcnrMove inline asm check to typeck, properly handle aliasesPull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. Tofixrust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.r? lcnr
Remove redundant checkWe still check for `rustc_on_unimplemented` on implementations, but this functionality was removed inrust-lang#139091, since then it always returns `Ok` when called with a non-trait defid.https://github.com/rust-lang/rust/blob/b4c8b0c3f0533bb342a4873ff59bdad3883ab8e3/compiler/rustc_trait_selection/src/error_reporting/traits/on_unimplemented.rs#L557-L564
…fn-kind-err, r=fee1-deadSimply try to unpeel AsyncFnKindHelper goal in `emit_specialized_closure_kind_error`Tweak the handling of `AsyncFnKindHelper` goals in `emit_specialized_closure_kind_error` to not be so special-casey, and just try to unpeel one or two layers of obligation causes to get to their underlying `AsyncFn*` goal.Fixesrust-lang#140292
…for-bufread-has-data-left-docs, r=jhprattGrammar fixes for BufRead::has_data_left docsFix some grammar in the documentation for `BufRead::has_data_left`
MemberAuthor
matthiaskrgr commentedApr 26, 2025
@bors r+ rollup=never p=5 |
Collaborator
bors commentedApr 26, 2025
Collaborator
bors commentedApr 26, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 26, 2025
…iaskrgrRollup of 7 pull requestsSuccessful merges: -rust-lang#123239 (Implement a lint for implicit autoref of raw pointer dereference - take 2) -rust-lang#140215 (transmutability: Support char, NonZeroXxx) -rust-lang#140226 (Update wasm-component-ld to 0.5.13) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140317 (Remove redundant check) -rust-lang#140318 (Simply try to unpeel AsyncFnKindHelper goal in `emit_specialized_closure_kind_error`) -rust-lang#140325 (Grammar fixes for BufRead::has_data_left docs)r? `@ghost``@rustbot` modify labels: rollup
Collaborator
rust-log-analyzer commentedApr 26, 2025
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
bors commentedApr 26, 2025
💔 Test failed -checks-actions |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
A-attributesArea: Attributes (`#[…]`, `#![…]`) rollupA PR which is a rollup S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. T-libsRelevant to the library team, which will review and decide on the PR/issue.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
emit_specialized_closure_kind_error#140318 (Simply try to unpeel AsyncFnKindHelper goal inemit_specialized_closure_kind_error)r?@ghost
@rustbot modify labels: rollup
Create a similar rollup