- Notifications
You must be signed in to change notification settings - Fork14.1k
Move inline asm check to typeck, properly handle aliases#140302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
rustbot commentedApr 25, 2025
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
| infcx, | ||
| typeck_results, | ||
| } | ||
| pub(crate)fnnew(def_id:LocalDefId,fcx:&'aFnCtxt<'a,'tcx>) ->Self{ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
pls swap argument order
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
or just recompute theDefId
Contributor
lcnr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
r=me after nits
51c0f33 tof769f42CompareContributor
lcnr commentedApr 25, 2025
@bors r+ rollup |
Collaborator
bors commentedApr 25, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull requestApr 26, 2025
…lcnrMove inline asm check to typeck, properly handle aliasesPull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. Tofixrust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.r? lcnr
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestApr 26, 2025
…lcnrMove inline asm check to typeck, properly handle aliasesPull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. Tofixrust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.r? lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 26, 2025
…iaskrgrRollup of 7 pull requestsSuccessful merges: -rust-lang#123239 (Implement a lint for implicit autoref of raw pointer dereference - take 2) -rust-lang#140215 (transmutability: Support char, NonZeroXxx) -rust-lang#140226 (Update wasm-component-ld to 0.5.13) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140317 (Remove redundant check) -rust-lang#140318 (Simply try to unpeel AsyncFnKindHelper goal in `emit_specialized_closure_kind_error`) -rust-lang#140325 (Grammar fixes for BufRead::has_data_left docs)r? `@ghost``@rustbot` modify labels: rollup
Member
matthiaskrgr commentedApr 26, 2025
f769f42 to3d7402bCompareCollaborator
rustbot commentedApr 27, 2025
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_codegen_cranelift cc@bjorn3 |
MemberAuthor
compiler-errors commentedApr 27, 2025
lmao some branches got crossed 💀 |
3d7402b tof769f42Comparef769f42 to3ab6051CompareContributor
lcnr commentedApr 28, 2025
@bors r+ rollup |
Collaborator
bors commentedApr 28, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull requestApr 28, 2025
…lcnrMove inline asm check to typeck, properly handle aliasesPull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. Tofixrust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.r? lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 28, 2025
…entonRollup of 9 pull requestsSuccessful merges: -rust-lang#139308 (add autodiff inline) -rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) -rust-lang#140374 (Resolve instance for SymFn in global/naked asm) -rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) -rust-lang#140394 (Make bootstrap git tests more self-contained) -rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) -rust-lang#140402 (only return nested goals for `Certainty::Yes`)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 28, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally`A revival ofrust-lang#124812.Current status:~~`./x.py b --stage 2` passes 🎉~~`try` builds succeed 🎉 🎉 🎉~~[top 100 most downloaded crates on crates.io compile](rust-lang#133502 (comment)[top 1000 most downloaded crates on crates.io compile](rust-lang#133502 (comment))[first perf run](rust-lang#133502 (comment)) 👻### in-flight changes-rust-lang#124852, unsure whether I actually want to land this PR for now-rust-lang#139587-https://github.com/lcnr/rust/tree/opaque-type-method-call-rust-lang#140302-rust-lang#140276-rust-lang#140260-rust-lang#140405r? `@ghost`
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull requestApr 28, 2025
…lcnrMove inline asm check to typeck, properly handle aliasesPull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. Tofixrust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.r? lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 28, 2025
…entonRollup of 10 pull requestsSuccessful merges: -rust-lang#139308 (add autodiff inline) -rust-lang#139656 (Stabilize `slice_as_chunks` library feature) -rust-lang#140022 (allow deref patterns to move out of boxes) -rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) -rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) -rust-lang#140394 (Make bootstrap git tests more self-contained) -rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) -rust-lang#140402 (only return nested goals for `Certainty::Yes`)Failed merges: -rust-lang#139765 ([beta] Delay `hash_extract_if` stabilization from 1.87 to 1.88)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 29, 2025
…entonRollup of 10 pull requestsSuccessful merges: -rust-lang#139308 (add autodiff inline) -rust-lang#139656 (Stabilize `slice_as_chunks` library feature) -rust-lang#140022 (allow deref patterns to move out of boxes) -rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) -rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) -rust-lang#140394 (Make bootstrap git tests more self-contained) -rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) -rust-lang#140402 (only return nested goals for `Certainty::Yes`)r? `@ghost``@rustbot` modify labels: rollup
3f5406f intorust-lang:master 6 checks passed
Uh oh!
There was an error while loading.Please reload this page.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestApr 29, 2025
Rollup merge ofrust-lang#140302 - compiler-errors:inline_asm-bug, r=lcnrMove inline asm check to typeck, properly handle aliasesPull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. Tofixrust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`.r? lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull requestApr 29, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally`A revival ofrust-lang#124812.Current status:~~`./x.py b --stage 2` passes 🎉~~`try` builds succeed 🎉 🎉 🎉~~[top 100 most downloaded crates on crates.io compile](rust-lang#133502 (comment)[top 1000 most downloaded crates on crates.io compile](rust-lang#133502 (comment))[first perf run](rust-lang#133502 (comment)) 👻### in-flight changes-rust-lang#124852, unsure whether I actually want to land this PR for now-rust-lang#139587-https://github.com/lcnr/rust/tree/opaque-type-method-call-rust-lang#140302-rust-lang#140276-rust-lang#140260-rust-lang#140405r? `@ghost`
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull
InlineAsmCtxtdown torustc_hir_typeck, and instead of using things likeTy::is_copy, use theInferCtxt-aware methods. Tofixrust-lang/trait-system-refactor-initiative#189, we also add atry_structurally_resolve_*call toexpr_ty.r? lcnr