- Notifications
You must be signed in to change notification settings - Fork14.1k
Stabilizeslice_as_chunks library feature#139656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rustbot commentedApr 11, 2025
rustbot has assigned@ibraheemdev. Use |
This comment has been minimized.
This comment has been minimized.
1f3dfae to6cfdd53Comparerustbot commentedApr 13, 2025
The Miri subtree was changed cc @rust-lang/miri |
scottmcm commentedApr 13, 2025
@rust-lang/libs-api I wanted to drop you a ping because therehas been a reasonable amount of discussion during the FCP, so if you want me to hold off this for a bit to give you discussion time, let me know. (I haven't seen any indication from comments that you've changed your minds, but it might just not have made it into the thread.) |
BurntSushi commentedApr 13, 2025
Aye yeah, I'm still good with this. But given the discussion, holding for a second from another libs-api member seems prudent. |
dtolnay commentedApr 13, 2025
LGTM as well. Thank you. We have talked about this feature across at least a half dozen library API team meetings and not diverged from favoring this design. |
| /// Panics if `N` is zero. This check will most probably get changed to a compile time | ||
| /// error before this method gets stabilized. | ||
| /// | ||
| /// # Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In the section above (which I cannot comment because it is too far from the diff) we need to strike"This check will most probably get changed to a compile time error before this method gets stabilized."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oops, that had even been mentioned in#74985 (comment) and I forgot.
Did a pass over the docs to fix that bit, elaborate on the resulting lengths, and also add a cross-references between these methods andas_flattened(_mut).
@rustbot ready
Also mention them from `as_flattened(_mut)`.
scottmcm commentedApr 28, 2025
Friendly ping here,@dtolnay |
dtolnay left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
dtolnay commentedApr 28, 2025
@bors r+ |
bors commentedApr 28, 2025
…, r=dtolnayStabilize `slice_as_chunks` library feature~~Draft as this needsrust-lang#139163 to land first.~~FCP:rust-lang#74985 (comment)Methods being stabilized are:```rustimpl [T] { const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]); const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]); const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]]; const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]); const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]); const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]];}```~~(FCP's not done quite yet, but will in another day if I'm counting right.)~~ FCP Complete:rust-lang#74985 (comment)
…entonRollup of 10 pull requestsSuccessful merges: -rust-lang#139308 (add autodiff inline) -rust-lang#139656 (Stabilize `slice_as_chunks` library feature) -rust-lang#140022 (allow deref patterns to move out of boxes) -rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) -rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) -rust-lang#140394 (Make bootstrap git tests more self-contained) -rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) -rust-lang#140402 (only return nested goals for `Certainty::Yes`)Failed merges: -rust-lang#139765 ([beta] Delay `hash_extract_if` stabilization from 1.87 to 1.88)r? `@ghost``@rustbot` modify labels: rollup
…entonRollup of 10 pull requestsSuccessful merges: -rust-lang#139308 (add autodiff inline) -rust-lang#139656 (Stabilize `slice_as_chunks` library feature) -rust-lang#140022 (allow deref patterns to move out of boxes) -rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) -rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) -rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) -rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) -rust-lang#140394 (Make bootstrap git tests more self-contained) -rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) -rust-lang#140402 (only return nested goals for `Certainty::Yes`)r? `@ghost``@rustbot` modify labels: rollup
17495e0 intorust-lang:masterUh oh!
There was an error while loading.Please reload this page.
Rollup merge ofrust-lang#139656 - scottmcm:stabilize-slice-as-chunks, r=dtolnayStabilize `slice_as_chunks` library feature~~Draft as this needsrust-lang#139163 to land first.~~FCP:rust-lang#74985 (comment)Methods being stabilized are:```rustimpl [T] { const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]); const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]); const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]]; const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]); const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]); const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]];}```~~(FCP's not done quite yet, but will in another day if I'm counting right.)~~ FCP Complete:rust-lang#74985 (comment)
…, r=dtolnayStabilize `slice_as_chunks` library feature~~Draft as this needsrust-lang#139163 to land first.~~FCP:rust-lang#74985 (comment)Methods being stabilized are:```rustimpl [T] { const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]); const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]); const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]]; const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]); const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]); const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]];}```~~(FCP's not done quite yet, but will in another day if I'm counting right.)~~ FCP Complete:rust-lang#74985 (comment)
Fix 1.88 relnotes- Use stable std links for `impl Default for {*const,*mut} T`- Add missing relnotes forrust-lang#139656 ```rs impl [T] { const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]); const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]); const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]]; const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]); const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]); const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]]; } ```- Add missing `mod ffi::c_str` and `hint::select_unpredictable`r? `@cuviper`Rollup merge of#143059 - jieyouxu:slice-as-chunks, r=cuviperFix 1.88 relnotes- Use stable std links for `impl Default for {*const,*mut} T`- Add missing relnotes for#139656 ```rs impl [T] { const fn as_chunks<const N: usize>(&self) -> (&[[T; N]], &[T]); const fn as_rchunks<const N: usize>(&self) -> (&[T], &[[T; N]]); const unsafe fn as_chunks_unchecked<const N: usize>(&self) -> &[[T; N]]; const fn as_chunks_mut<const N: usize>(&mut self) -> (&mut [[T; N]], &mut [T]); const fn as_rchunks_mut<const N: usize>(&mut self) -> (&mut [T], &mut [[T; N]]); const unsafe fn as_chunks_unchecked_mut<const N: usize>(&mut self) -> &mut [[T; N]]; } ```- Add missing `mod ffi::c_str` and `hint::select_unpredictable`r? `@cuviper`
Uh oh!
There was an error while loading.Please reload this page.
Draft as this needs#139163 to land first.FCP:#74985 (comment)
Methods being stabilized are:
(FCP's not done quite yet, but will in another day if I'm counting right.)FCP Complete:#74985 (comment)