Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Addf16 andf128 inline ASM support foraarch64#129536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bors merged 2 commits intorust-lang:masterfrombeetrees:f16-f128-inline-asm-aarch64
Aug 27, 2024

Conversation

@beetrees
Copy link
Contributor

@beetreesbeetrees commentedAug 24, 2024•
edited by tgross35
Loading

Addsf16 andf128 inline ASM support foraarch64. SIMD vector types are taken fromthe ARM intrinsics list. Based on the work of@lengrongfu in#127043.

Relevant issue:#125398
Tracking issue:#116909

@rustbot label +F-f16_and_f128

try-job: aarch64-gnu
try-job: aarch64-apple

@rustbot
Copy link
Collaborator

r?@davidtwco

rustbot has assigned@davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

User? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]` labelsAug 24, 2024
@tgross35
Copy link
Contributor

tgross35 commentedAug 25, 2024•
edited
Loading

Thanks for getting this over the line, and thanks@lengrongfu for getting this started.

r?@Amanieu from the other asm changes

@rustbotrustbot assignedAmanieu and unassigneddavidtwcoAug 25, 2024
@Amanieu
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

📌 Commitabd44fc has been approved byAmanieu

It is now in thequeue for this repository.

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelsAug 26, 2024
@tgross35
Copy link
Contributor

There are at least a few jobs in the queue before this will get picked up. Might as well use that time to verify the tests here.
@bors r-

@borsbors added S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. labelsAug 27, 2024
@tgross35
Copy link
Contributor

@bors try

@bors
Copy link
Collaborator

⌛ Trying commitabd44fc with mergee6fadc6...

bors added a commit to rust-lang-ci/rust that referenced this pull requestAug 27, 2024
…, r=<try>Add `f16` and `f128` inline ASM support for `aarch64`Adds `f16` and `f128` inline ASM support for `aarch64`. SIMD vector types are taken from [the ARM intrinsics list](https://developer.arm.com/architectures/instruction-sets/intrinsics/#f:`@navigationhierarchiesreturnbasetype=[float]&f:@navigationhierarchieselementbitsize=[16]&f:@navigationhierarchiesarchitectures=[A64]).` Based on the work of `@lengrongfu` inrust-lang#127043.Relevant issue:rust-lang#125398Tracking issue:rust-lang#116909`@rustbot` label +F-f16_and_f128try-job: aarch64-gnutry-job: aarch64-apple
@rust-log-analyzer
Copy link
Collaborator

The jobaarch64-apple failed! Check out the build log:(web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
Updating files:  98% (48254/49238)Updating files:  99% (48746/49238)Updating files: 100% (49238/49238)Updating files: 100% (49238/49238), done.Switched to a new branch 'try'branch 'try' set up to track 'origin/try'.[command]/opt/homebrew/bin/git log -1 --format='%H''e6fadc641686689bc944772b2687b843130a8680'##[group]Run src/ci/scripts/setup-environment.shsrc/ci/scripts/setup-environment.sh---file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rustfile:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*file:.git/config gc.auto=0file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***file:.git/config branch.try.remote=originfile:.git/config branch.try.merge=refs/heads/tryfile:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.gitfile:.git/config submodule.library/stdarch.active=truefile:.git/config submodule.library/stdarch.url=https://github.com/rust-lang/stdarch.gitfile:.git/config submodule.src/doc/book.active=true---fmt checkfmt: skipped untracked file AWSCLIV2.pkgfmt: checked 5511 filestidy checkthread 'deps (.)' panicked at src/tools/tidy/src/deps.rs:587:24:cmd.exec() failed with `cargo metadata` exited with an error:     Updating crates.io indexwarning: spurious network error (3 tries remaining): unexpected http status code: 429; class=Http (34)warning: spurious network error (2 tries remaining): unexpected http status code: 429; class=Http (34)warning: spurious network error (1 tries remaining): unexpected http status code: 429; class=Http (34)warning: spurious network error (1 tries remaining): unexpected http status code: 429; class=Http (34)error: failed to get `rust_team_data` as a dependency of package `site v0.1.0 (/Users/runner/work/rust/rust/src/tools/rustc-perf/site)`Caused by:  failed to load source for dependency `rust_team_data`Caused by:Caused by:  Unable to update https://github.com/rust-lang/team#a5260e76Caused by:  failed to clone into: /Users/runner/.cargo/git/db/team-8b970833d5192347Caused by:  network failure seems to have happened  if a proxy or similar is necessary `net.git-fetch-with-cli` may help here  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli  https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cliCaused by:  unexpected http status code: 429; class=Http (34)note: run with `RUST_BACKTRACE=1` environment variable to display a backtracethread 'main' panicked at src/tools/tidy/src/main.rs:60:49:called `Result::unwrap()` on an `Err` value: Any { .. }Command has failed. Rerun with -v to see more details.  local time: Tue Aug 27 04:59:03 UTC 2024  network time: Tue, 27 Aug 2024 04:59:03 GMT##[error]Process completed with exit code 1.Post job cleanup.

@bors
Copy link
Collaborator

💔 Test failed -checks-actions

@tgross35
Copy link
Contributor

@bors try network failure

@bors
Copy link
Collaborator

⌛ Trying commitabd44fc with merge2e5b402...

bors added a commit to rust-lang-ci/rust that referenced this pull requestAug 27, 2024
…, r=<try>Add `f16` and `f128` inline ASM support for `aarch64`Adds `f16` and `f128` inline ASM support for `aarch64`. SIMD vector types are taken from [the ARM intrinsics list](https://developer.arm.com/architectures/instruction-sets/intrinsics/#f:`@navigationhierarchiesreturnbasetype=[float]&f:@navigationhierarchieselementbitsize=[16]&f:@navigationhierarchiesarchitectures=[A64]).` Based on the work of `@lengrongfu` inrust-lang#127043.Relevant issue:rust-lang#125398Tracking issue:rust-lang#116909`@rustbot` label +F-f16_and_f128try-job: aarch64-gnutry-job: aarch64-apple
@bors
Copy link
Collaborator

☀️ Try build successful -checks-actions
Build commit:2e5b402 (2e5b402ee6c393514d53db5991da504f22dcd2a6)

@tgross35
Copy link
Contributor

@bors r=Amanieu

@bors
Copy link
Collaborator

📌 Commitabd44fc has been approved byAmanieu

It is now in thequeue for this repository.

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author. labelsAug 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull requestAug 27, 2024
Rollup of 9 pull requestsSuccessful merges: -rust-lang#126985 (Implement `-Z embed-source` (DWARFv5 source code embedding extension)) -rust-lang#127922 (Add unsafe to extern blocks in style guide) -rust-lang#128731 (simd_shuffle intrinsic: allow argument to be passed as vector) -rust-lang#128935 (More work on `zstd` compression) -rust-lang#128942 (miri weak memory emulation: put previous value into initial store buffer) -rust-lang#129418 (rustc: Simplify getting sysroot library directory) -rust-lang#129490 (Add Trusty OS as tier 3 target) -rust-lang#129536 (Add `f16` and `f128` inline ASM support for `aarch64`) -rust-lang#129559 (float types: document NaN bit pattern guarantees)r? `@ghost``@rustbot` modify labels: rollup
@borsbors merged commit8ea70e9 intorust-lang:masterAug 27, 2024
@rustbotrustbot added this to the1.82.0 milestoneAug 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestAug 27, 2024
Rollup merge ofrust-lang#129536 - beetrees:f16-f128-inline-asm-aarch64, r=AmanieuAdd `f16` and `f128` inline ASM support for `aarch64`Adds `f16` and `f128` inline ASM support for `aarch64`. SIMD vector types are taken from [the ARM intrinsics list](https://developer.arm.com/architectures/instruction-sets/intrinsics/#f:`@navigationhierarchiesreturnbasetype=[float]&f:@navigationhierarchieselementbitsize=[16]&f:@navigationhierarchiesarchitectures=[A64]).` Based on the work of `@lengrongfu` inrust-lang#127043.Relevant issue:rust-lang#125398Tracking issue:rust-lang#116909`@rustbot` label +F-f16_and_f128try-job: aarch64-gnutry-job: aarch64-apple
@beetreesbeetrees deleted the f16-f128-inline-asm-aarch64 branchAugust 27, 2024 10:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@AmanieuAmanieu

Labels

F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

8 participants

@beetrees@rustbot@tgross35@Amanieu@bors@rust-log-analyzer@davidtwco@lengrongfu
[8]ページ先頭
©2009-2025 Movatter.jp