- Notifications
You must be signed in to change notification settings - Fork14.1k
Updatef16/f128 FIXMEs that needed(NEG_)INFINITY#127496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ContributorAuthor
tgross35 commentedJul 8, 2024
Seems like an unlikely change to cause a new segfault 😄 |
95a19d1 to4d506f7Compare4d506f7 to96a7916Compare92 tasks
Member
Nadrieril commentedJul 9, 2024
Nice! Glad you got it to work. @bors r+ |
Collaborator
bors commentedJul 9, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJul 9, 2024
…=NadrierilUpdate `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`Just a small fix to the pattern matching tests now that we can. Also contains a small unrelated comment tweak.
bors added a commit to rust-lang-ci/rust that referenced this pull requestJul 9, 2024
…iaskrgrRollup of 8 pull requestsSuccessful merges: -rust-lang#127028 (Fix regression in the MIR lowering of or-patterns) -rust-lang#127091 (impl FusedIterator and a size hint for the error sources iter) -rust-lang#127358 (Automatically taint when reporting errors from ItemCtxt) -rust-lang#127382 (Use verbose style when suggesting changing `const` with `let`) -rust-lang#127397 (fix interleaved output in the default panic hook when multiple threads panic simultaneously) -rust-lang#127484 (`#[doc(alias)]`'s doc: say that ASCII spaces are allowed) -rust-lang#127496 (Update `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`) -rust-lang#127508 (small search graph refactor)r? `@ghost``@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJul 9, 2024
…=NadrierilUpdate `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`Just a small fix to the pattern matching tests now that we can. Also contains a small unrelated comment tweak.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJul 9, 2024
…=NadrierilUpdate `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`Just a small fix to the pattern matching tests now that we can. Also contains a small unrelated comment tweak.
bors added a commit to rust-lang-ci/rust that referenced this pull requestJul 9, 2024
…iaskrgrRollup of 7 pull requestsSuccessful merges: -rust-lang#127091 (impl FusedIterator and a size hint for the error sources iter) -rust-lang#127358 (Automatically taint when reporting errors from ItemCtxt) -rust-lang#127382 (Use verbose style when suggesting changing `const` with `let`) -rust-lang#127484 (`#[doc(alias)]`'s doc: say that ASCII spaces are allowed) -rust-lang#127495 (More trait error reworking) -rust-lang#127496 (Update `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`) -rust-lang#127508 (small search graph refactor)r? `@ghost``@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJul 9, 2024
…=NadrierilUpdate `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`Just a small fix to the pattern matching tests now that we can. Also contains a small unrelated comment tweak.
bors added a commit to rust-lang-ci/rust that referenced this pull requestJul 9, 2024
…iaskrgrRollup of 10 pull requestsSuccessful merges: -rust-lang#124339 (allow overwriting the output of `rustc --version`) -rust-lang#125627 (migration lint for `expr2024` for the edition 2024) -rust-lang#127091 (impl FusedIterator and a size hint for the error sources iter) -rust-lang#127358 (Automatically taint when reporting errors from ItemCtxt) -rust-lang#127484 (`#[doc(alias)]`'s doc: say that ASCII spaces are allowed) -rust-lang#127495 (More trait error reworking) -rust-lang#127496 (Update `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`) -rust-lang#127508 (small search graph refactor) -rust-lang#127521 (Remove spastorino from SMIR) -rust-lang#127532 (documentation: update cmake version)r? `@ghost``@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJul 9, 2024
…=NadrierilUpdate `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`Just a small fix to the pattern matching tests now that we can. Also contains a small unrelated comment tweak.
bors added a commit to rust-lang-ci/rust that referenced this pull requestJul 9, 2024
…iaskrgrRollup of 8 pull requestsSuccessful merges: -rust-lang#127091 (impl FusedIterator and a size hint for the error sources iter) -rust-lang#127358 (Automatically taint when reporting errors from ItemCtxt) -rust-lang#127484 (`#[doc(alias)]`'s doc: say that ASCII spaces are allowed) -rust-lang#127495 (More trait error reworking) -rust-lang#127496 (Update `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`) -rust-lang#127508 (small search graph refactor) -rust-lang#127521 (Remove spastorino from SMIR) -rust-lang#127532 (documentation: update cmake version)r? `@ghost``@rustbot` modify labels: rollup
Collaborator
bors commentedJul 10, 2024
Collaborator
bors commentedJul 10, 2024
☀️ Test successful -checks-actions |
Collaborator
rust-timer commentedJul 10, 2024
Finished benchmarking commit (7caf672):comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -3.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 702.638s -> 703.707s (0.15%) |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]` merged-by-borsThis PR was explicitly merged by bors. S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Just a small fix to the pattern matching tests now that we can. Also contains a small unrelated comment tweak.
@rustbot label +F-f16_and_f128
r?@Nadrieril