- Notifications
You must be signed in to change notification settings - Fork14.1k
Rollup of 9 pull requests#127056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Rollup of 9 pull requests#127056
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Syntax extensions are replaced by proc macros.- Add rationale for why AST validation pass need to be run post-expansion and why the pass is needed in the first place.
This commit was obtained by repeatedly inlining and simplifying.
It is only implemented for a single type. Directly passing this type issimpler and avoids overhead from indirect calls.
It can be retrieved from the Session too.
They are not representable by Cranelift
This commit too was obtained by repeatedly inlining and simplifying.
as request T-lang is requesting some major changes in the lint innerworkings inrust-lang#126768#issuecomment-2192634762
These table entries have wrong number of columns so the "notes" field ismissing from the rendered page. Fix by removing excess empty columns.
…ler-errorsVarious rustc_codegen_ssa cleanups
Add test for fn pointer duplication.I managed to make it fail when removing provenance checks in GVN.ccrust-lang#123670r? ``@oli-obk``
…docs, r=wesleywiserUpdate AST validation module docsDrive-by doc update for AST validation pass:- Syntax extensions are replaced by proc macros.- Add rationale for why AST validation pass need to be run post-expansion and why the pass is needed in the first place.This was discussed during this week's [rustc-dev-guide reading club](https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide), and the rationale was explained by cc ``@bjorn3.``
…atthewjasperSimplifications in match loweringA series of small simplifications and deduplications in the MIR lowering of patterns.r? ``@matthewjasper``
…ive, r=oli-obkAdd basic Serde serialization capabilities to Stable MIRThis PR adds basic Serde serialization capabilities to Stable MIR. It is intentionally minimal (just wrapping all stable MIR types with a Serde `derive`), so that any important design decisions can be discussed before going further. A simple test is included with this PR to validate that JSON can actually be emitted.## NotesWhen I wrapped the Stable MIR error types in `compiler/stable_mir/src/error.rs`, it caused test failures (though I'm not sure why) so I backed those out.## Future WorkSo, this PR will support serializing basic stable MIR, but it _does not_ support serializing interned values beneath `Ty`s and `AllocId`s, etc... My current thinking about how to handle this is as follows:1. Add new `visited_X` fields to the `Tables` struct for each interned category of interest.2. As serialization is occuring, serialize interned values as usual _and_ also record the interned value we referenced in `visited_X`. (Possibly) In addition, if an interned value recursively references other interned values, record those interned values as well.3. Teach the stable MIR `Context` how to access the `visited_X` values and expose them with wrappers in `stable_mir/src/lib.rs` to users (e.g. to serialize and/or further analyze them).### ProsThis approach does not commit to any specific serialization format regarding interned values or other more complex cases, which avoids us locking into any behaviors that may not be desired long-term.### ConsThe user will need to manually handle serializing interned values.### Alternatives1. We can directly provide access to the underlying `Tables` maps for interned values; the disadvantage of this approach is that it either requires extra processing for users to filter out to only use the values that they need _or_ users may serialize extra values that they don't need. The advantage is that the implementation is even simpler. The other pros/cons are similar to the above.2. We can directly serialize interned values by expanding them in-place. The pro is that this may make some basic inputs easier to consume. However, the cons are that there will need to be special provisions for dealing with cyclical values on both the producer and consumer _and_ global values will possibly need to be de-duplicated on the consumer side.
…=notriddleUpdate browser-ui-test version to `0.18.0`Should help withrust-lang#126436.r? ``@notriddle``
Switch back `non_local_definitions` lint to allow-by-defaultThis PR switch back (again) the `non_local_definitions` lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings inrust-lang#126768 (comment).This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.
…r=lqdFix Markdown tables in platform-support.mdThese table entries have wrong number of columns so the "notes" field is missing from the rendered page. Fix by removing excess empty columns.
… r=oli-obkEnable const casting for `f16` and `f128`I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.Cc ``@RalfJung``
MemberAuthor
matthiaskrgr commentedJun 27, 2024
@bors r+ rollup=never p=9 |
Collaborator
bors commentedJun 27, 2024
Collaborator
bors commentedJun 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 27, 2024
…iaskrgrRollup of 9 pull requestsSuccessful merges: -rust-lang#123237 (Various rustc_codegen_ssa cleanups) -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126835 (Simplifications in match lowering) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127010 (Update browser-ui-test version to `0.18.0`) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`)r? `@ghost``@rustbot` modify labels: rollup
Collaborator
rust-log-analyzer commentedJun 27, 2024
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
bors commentedJun 27, 2024
💔 Test failed -checks-actions |
MemberAuthor
matthiaskrgr commentedJun 28, 2024
@bors retry probably spurious |
Contributor
tgross35 commentedJun 28, 2024
Fyi this is racing with#127064 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustc rollupA PR which is a rollup S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
0.18.0#127010 (Update browser-ui-test version to0.18.0)non_local_definitionslint to allow-by-default #127015 (Switch backnon_local_definitionslint to allow-by-default)f16andf128#127032 (Enable const casting forf16andf128)r?@ghost
@rustbot modify labels: rollup
Create a similar rollup