Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rollup of 9 pull requests#127056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@matthiaskrgr
Copy link
Member

Successful merges:

r?@ghost
@rustbot modify labels: rollup

Create a similar rollup

jieyouxuand others added30 commitsApril 17, 2024 19:23
- Syntax extensions are replaced by proc macros.- Add rationale for why AST validation pass need to be run  post-expansion and why the pass is needed in the first place.
This commit was obtained by repeatedly inlining and simplifying.
It is only implemented for a single type. Directly passing this type issimpler and avoids overhead from indirect calls.
It can be retrieved from the Session too.
They are not representable by Cranelift
This commit too was obtained by repeatedly inlining and simplifying.
as request T-lang is requesting some major changes in the lint innerworkings inrust-lang#126768#issuecomment-2192634762
These table entries have wrong number of columns so the "notes" field ismissing from the rendered page. Fix by removing excess empty columns.
Add test for fn pointer duplication.I managed to make it fail when removing provenance checks in GVN.ccrust-lang#123670r? ``@oli-obk``
…docs, r=wesleywiserUpdate AST validation module docsDrive-by doc update for AST validation pass:- Syntax extensions are replaced by proc macros.- Add rationale for why AST validation pass need to be run  post-expansion and why the pass is needed in the first place.This was discussed during this week's [rustc-dev-guide reading club](https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide), and the rationale was explained by cc ``@bjorn3.``
…atthewjasperSimplifications in match loweringA series of small simplifications and deduplications in the MIR lowering of patterns.r? ``@matthewjasper``
…ive, r=oli-obkAdd basic Serde serialization capabilities to Stable MIRThis PR adds basic Serde serialization capabilities to Stable MIR. It is intentionally minimal (just wrapping all stable MIR types with a Serde `derive`), so that any important design decisions can be discussed before going further. A simple test is included with this PR to validate that JSON can actually be emitted.## NotesWhen I wrapped the Stable MIR error types in `compiler/stable_mir/src/error.rs`, it caused test failures (though I'm not sure why) so I backed those out.## Future WorkSo, this PR will support serializing basic stable MIR, but it _does not_ support serializing interned values beneath `Ty`s and `AllocId`s, etc... My current thinking about how to handle this is as follows:1.  Add new `visited_X` fields to the `Tables` struct for each interned category of interest.2.  As serialization is occuring, serialize interned values as usual _and_ also record the interned value we referenced in `visited_X`.    (Possibly) In addition, if an interned value recursively references other interned values, record those interned values as well.3.  Teach the stable MIR `Context` how to access the `visited_X` values and expose them with wrappers in `stable_mir/src/lib.rs` to users (e.g. to serialize and/or further analyze them).### ProsThis approach does not commit to any specific serialization format regarding interned values or other more complex cases, which avoids us locking into any behaviors that may not be desired long-term.### ConsThe user will need to manually handle serializing interned values.### Alternatives1.  We can directly provide access to the underlying `Tables` maps for interned values; the disadvantage of this approach is that it either requires extra processing for users to filter out to only use the values that they need _or_ users may serialize extra values that they don't need. The advantage is that the implementation is even simpler. The other pros/cons are similar to the above.2.  We can directly serialize interned values by expanding them in-place. The pro is that this may make some basic inputs easier to consume. However, the cons are that there will need to be special provisions for dealing with cyclical values on both the producer and consumer _and_ global values will possibly need to be de-duplicated on the consumer side.
…=notriddleUpdate browser-ui-test version to `0.18.0`Should help withrust-lang#126436.r? ``@notriddle``
Switch back `non_local_definitions` lint to allow-by-defaultThis PR switch back (again) the `non_local_definitions` lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings inrust-lang#126768 (comment).This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.
…r=lqdFix Markdown tables in platform-support.mdThese table entries have wrong number of columns so the "notes" field is missing from the rendered page. Fix by removing excess empty columns.
… r=oli-obkEnable const casting for `f16` and `f128`I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.Cc ``@RalfJung``
@rustbotrustbot added A-testsuiteArea: The testsuite used to check the correctness of rustc S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue. rollupA PR which is a rollup labelsJun 27, 2024
@matthiaskrgr
Copy link
MemberAuthor

@bors r+ rollup=never p=9

@bors
Copy link
Collaborator

📌 Commit11cff7d has been approved bymatthiaskrgr

It is now in thequeue for this repository.

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelsJun 27, 2024
@bors
Copy link
Collaborator

⌛ Testing commit11cff7d with merge4b2a005...

bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 27, 2024
…iaskrgrRollup of 9 pull requestsSuccessful merges: -rust-lang#123237 (Various rustc_codegen_ssa cleanups) -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126835 (Simplifications in match lowering) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127010 (Update browser-ui-test version to `0.18.0`) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`)r? `@ghost``@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The jobx86_64-msvc-ext failed! Check out the build log:(web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
        ---- abi.md - Application_Binary_Interface__ABI_::The_ (line 20) stdout ----    error: linking with `link.exe` failed: exit code: 1120      |      = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.40.33807\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "C:\\a\\_temp\\msys64\\tmp\\rustchwNUXt\\symbols.o" "C:\\a\\_temp\\msys64\\tmp\\rustdoctestSvh4YH\\rust_out.rust_out.44cc1c54a6338953-cgu.0.rcgu.o" "C:\\a\\_temp\\msys64\\tmp\\rustdoctestSvh4YH\\rust_out.di9umzx7rjuv9vxkbczfbmnh3.rcgu.o" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-206083cb6bc4d475.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-99645fe50ce44166.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_demangle-61b4562231042fd0.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd_detect-81cfc1256b6fbf6e.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libhashbrown-32b5e8b3646f8f41.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_alloc-eff6e1d33fba116e.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-90643aa787b02322.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcfg_if-c83f178b1eb06b75.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-49b3a906698dafaf.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librustc_std_workspace_core-ced70f8369d90b15.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-e4d31ad4edfac595.rlib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-b05085058f881bfe.rlib" "kernel32.lib" "advapi32.lib" "kernel32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "kernel32.lib" "ws2_32.lib" "kernel32.lib" "/defaultlib:msvcrt" "/NXCOMPAT" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "/OUT:C:\\a\\_temp\\msys64\\tmp\\rustdoctestSvh4YH\\rust_out.exe" "/OPT:REF,NOICF" "/DEBUG" "/PDBALTPATH:%_PDB%"      = note: symbols.o : error LNK2001: unresolved external symbol _ZN8rust_out4main25_doctest_main_abi_md_20_03FOO17h833457f3d65cefdeE              C:\a\_temp\msys64\tmp\rustdoctestSvh4YH\rust_out.exe : fatal error LNK1120: 1 unresolved externals        error: aborting due to 1 previous error        Couldn't compile the test.---[RUSTC-TIMING] llvm_bitcode_linker test:false 1.681    Finished `release` profile [optimized] target(s) in 0.36s[TIMING] core::build_steps::tool::LlvmBitcodeLinker { compiler: Compiler { stage: 0, host: x86_64-pc-windows-msvc }, target: x86_64-pc-windows-msvc, extra_features: [] } -- 0.396thread 'main' panicked at src/lib.rs:1713:17:failed to copy `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-rustc\x86_64-pc-windows-msvc\release\rustc-main.exe` to `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1\bin\rustc.exe`: The process cannot access the file because it is being used by another process. (os error 32)Build completed unsuccessfully in 0:00:05  local time: Thu, Jun 27, 2024 10:37:13 PM  network time: Thu, 27 Jun 2024 22:37:14 GMT##[error]Process completed with exit code 1.

@bors
Copy link
Collaborator

💔 Test failed -checks-actions

@borsbors added S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. labelsJun 27, 2024
@matthiaskrgr
Copy link
MemberAuthor

@bors retry probably spurious

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelsJun 28, 2024
@tgross35
Copy link
Contributor

Fyi this is racing with#127064

@matthiaskrgrmatthiaskrgr deleted the rollup-9cyvjqp branchSeptember 1, 2024 17:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-log-analyzer@tgross35@rustbot@jieyouxu@cjgillot@Nadrieril@bjorn3@GuillaumeGomez@Urgau@xen0n

[8]ページ先頭

©2009-2025 Movatter.jp