- Notifications
You must be signed in to change notification settings - Fork14.1k
Enable const casting forf16 andf128#127032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
rustbot commentedJun 27, 2024
rustbot has assigned@compiler-errors. Use |
Collaborator
rustbot commentedJun 27, 2024
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
oli-obk approved these changesJun 27, 2024
Contributor
oli-obk commentedJun 27, 2024
Collaborator
bors commentedJun 27, 2024
ContributorAuthor
tgross35 commentedJun 27, 2024
That was fast 😆 thanks! |
Contributor
oli-obk commentedJun 27, 2024
Technically you should be able to test this from const eval now, right? |
Contributor
oli-obk commentedJun 27, 2024
@bors rollup |
ContributorAuthor
tgross35 commentedJun 27, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah I think this unblocks the only exposed codepath, the remaining changes in miri are just intrinsics that we don't have library functions for. Miri just has a good structure for casting tests so it seems easiest to make use of what is there |
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull requestJun 27, 2024
… r=oli-obkEnable const casting for `f16` and `f128`I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.Cc `@RalfJung`
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 27, 2024
…llaumeGomezRollup of 10 pull requestsSuccessful merges: -rust-lang#123237 (Various rustc_codegen_ssa cleanups) -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126835 (Simplifications in match lowering) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127010 (Update browser-ui-test version to `0.18.0`) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127016 (docs: check if the disambiguator matches its suffix) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`)r? `@ghost``@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJun 27, 2024
… r=oli-obkEnable const casting for `f16` and `f128`I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.Cc ``@RalfJung``
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 27, 2024
…iaskrgrRollup of 9 pull requestsSuccessful merges: -rust-lang#123237 (Various rustc_codegen_ssa cleanups) -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126835 (Simplifications in match lowering) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127010 (Update browser-ui-test version to `0.18.0`) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`)r? `@ghost``@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull requestJun 28, 2024
… r=oli-obkEnable const casting for `f16` and `f128`I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.Cc ```@RalfJung```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJun 28, 2024
… r=oli-obkEnable const casting for `f16` and `f128`I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.Cc ````@RalfJung````
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 28, 2024
…iaskrgrRollup of 8 pull requestsSuccessful merges: -rust-lang#123237 (Various rustc_codegen_ssa cleanups) -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126835 (Simplifications in match lowering) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 28, 2024
…iaskrgrRollup of 8 pull requestsSuccessful merges: -rust-lang#123237 (Various rustc_codegen_ssa cleanups) -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126835 (Simplifications in match lowering) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`)r? `@ghost``@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull requestJun 28, 2024
… r=oli-obkEnable const casting for `f16` and `f128`I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.Cc `````@RalfJung`````
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 28, 2024
…iaskrgrRollup of 8 pull requestsSuccessful merges: -rust-lang#123237 (Various rustc_codegen_ssa cleanups) -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126835 (Simplifications in match lowering) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 28, 2024
…llaumeGomezRollup of 10 pull requestsSuccessful merges: -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127016 (docs: check if the disambiguator matches its suffix) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`) -rust-lang#127041 (Migrate `run-make/override-aliased-flags` to `rmake.rs`) -rust-lang#127045 (Rename `super_predicates_of` and similar queries to `explicit_*` to note that they're not elaborated) -rust-lang#127075 (rustc_data_structures: Explicitly check for 64-bit atomics support)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 28, 2024
…iaskrgrRollup of 8 pull requestsSuccessful merges: -rust-lang#123237 (Various rustc_codegen_ssa cleanups) -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#126835 (Simplifications in match lowering) -rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 28, 2024
…iaskrgrRollup of 11 pull requestsSuccessful merges: -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127016 (docs: check if the disambiguator matches its suffix) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`) -rust-lang#127055 (Mark Hasher::finish as #[must_use]) -rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params) -rust-lang#127070 (add () to the marker_impls macro for ConstParamTy) -rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods) -rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 29, 2024
…iaskrgrRollup of 11 pull requestsSuccessful merges: -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127016 (docs: check if the disambiguator matches its suffix) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`) -rust-lang#127055 (Mark Hasher::finish as #[must_use]) -rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params) -rust-lang#127070 (add () to the marker_impls macro for ConstParamTy) -rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods) -rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 29, 2024
…iaskrgrRollup of 11 pull requestsSuccessful merges: -rust-lang#123714 (Add test for fn pointer duplication.) -rust-lang#124091 (Update AST validation module docs) -rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default) -rust-lang#127016 (docs: check if the disambiguator matches its suffix) -rust-lang#127029 (Fix Markdown tables in platform-support.md) -rust-lang#127032 (Enable const casting for `f16` and `f128`) -rust-lang#127055 (Mark Hasher::finish as #[must_use]) -rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params) -rust-lang#127070 (add () to the marker_impls macro for ConstParamTy) -rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods) -rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)r? `@ghost``@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestJun 29, 2024
Rollup merge ofrust-lang#127032 - tgross35:f16-f128-const-eval-cast, r=oli-obkEnable const casting for `f16` and `f128`I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.Cc ``````@RalfJung``````
92 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an open PR to the Miri repo adding tests for this behaviorrust-lang/miri#3688, but that unfortunately hits the ICE path here. The changes seem reasonably low risk that it might be okay to merge separately from the tests, and I tested the result locally against an older version ofrust-lang/miri#3688.
Cc@RalfJung