- Notifications
You must be signed in to change notification settings - Fork14.1k
Allow "C-unwind" fn to have C variadics#126843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
bors merged 2 commits intorust-lang:masterfromworkingjubilee:allow-variadics-in-c-unwindJun 23, 2024
Merged
Allow "C-unwind" fn to have C variadics#126843
bors merged 2 commits intorust-lang:masterfromworkingjubilee:allow-variadics-in-c-unwindJun 23, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
rustbot commentedJun 22, 2024
rustbot has assigned@nnethercote. Use |
Contributor
nnethercote commentedJun 23, 2024
I think you need to update the
r=me with that. |
MemberAuthor
workingjubilee commentedJun 23, 2024
ah, good catch! |
Contributor
nnethercote commentedJun 23, 2024
@bors r+ |
Collaborator
bors commentedJun 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 23, 2024
…iaskrgrRollup of 5 pull requestsSuccessful merges: -rust-lang#126720 (Ignore `branch-protection-check-IBT` run-make test) -rust-lang#126779 (Try to clarify the confusingly-named `RustDev` and `RustcDev` steps) -rust-lang#126782 (Support absolute source paths in bootstrap) -rust-lang#126783 (Fix issue number for the `tcplistener_into_incoming` feature) -rust-lang#126843 (Allow "C-unwind" fn to have C variadics)r? `@ghost``@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestJun 23, 2024
Rollup merge ofrust-lang#126843 - workingjubilee:allow-variadics-in-c-unwind, r=nnethercoteAllow "C-unwind" fn to have C variadicsFixesrust-lang#126836
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
F-c_unwind`#![feature(c_unwind)]` F-c_variadic`#![feature(c_variadic)]` S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#126836