Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Usestd::path::absolute in bootstrap#126488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bors merged 1 commit intorust-lang:masterfromChrisDenton:absolute
Jun 15, 2024
Merged

Conversation

@ChrisDenton
Copy link
Member

@ChrisDentonChrisDenton commentedJun 14, 2024•
edited
Loading

std::path::absolute is now stable in 1.79 so we can get rid of the copy-pasted version.

mati865, Luracasmus, and Kobzol reacted with rocket emoji
@rustbot
Copy link
Collaborator

r?@albertlarsan68

rustbot has assigned@albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

User? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labelsJun 14, 2024
@rustbot
Copy link
Collaborator

This PR modifiessrc/bootstrap/src/core/config.

If appropriate, please updateCONFIG_CHANGE_HISTORY insrc/bootstrap/src/utils/change_tracker.rs.

@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+

@bors
Copy link
Collaborator

📌 Commitae070b7 has been approved byalbertlarsan68

It is now in thequeue for this repository.

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelsJun 14, 2024
@rust-log-analyzer

This comment has been minimized.

@ChrisDenton
Copy link
MemberAuthor

That's a weird failure and seems unrelated. I'm sure I've seen that before somewhere though.

@ChrisDenton
Copy link
MemberAuthor

ChrisDenton commentedJun 14, 2024•
edited
Loading

Edit: sorry for the spurious ping. That's my failure it's just that rustbot pointed to the wrong thing. Sorry again!

@ChrisDenton
Copy link
MemberAuthor

So it turned out I missed a test. Removed now.

@ChrisDenton
Copy link
MemberAuthor

CI is green

@bors r=albertlarsan68

@bors
Copy link
Collaborator

📌 Commit78d4802 has been approved byalbertlarsan68

It is now in thequeue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJun 15, 2024
…an68Use `std::path::absolute` in bootstrap`std::path::absolute` is now stable in 1.79 so we can get rid of the copy-pasted version.
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
…iaskrgrRollup of 10 pull requestsSuccessful merges: -rust-lang#125829 (rustc_span: Add conveniences for working with span formats) -rust-lang#126279 (Migrate `inaccessible-temp-dir`, `output-with-hyphens` and `issue-10971-temps-dir` `run-make` tests to `rmake`) -rust-lang#126361 (Unify intrinsics body handling in StableMIR) -rust-lang#126417 (Add `f16` and `f128` inline ASM support for `x86` and `x86-64`) -rust-lang#126424 ( Also sort `crt-static` in `--print target-features` output) -rust-lang#126428 (Polish `std::path::absolute` documentation.) -rust-lang#126429 (Add `f16` and `f128` const eval for binary and unary operationations) -rust-lang#126448 (End support for Python 3.8 in tidy) -rust-lang#126488 (Use `std::path::absolute` in bootstrap) -rust-lang#126511 (.mailmap: Associate both my work and my private email with me)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
…iaskrgrRollup of 9 pull requestsSuccessful merges: -rust-lang#125829 (rustc_span: Add conveniences for working with span formats) -rust-lang#126361 (Unify intrinsics body handling in StableMIR) -rust-lang#126417 (Add `f16` and `f128` inline ASM support for `x86` and `x86-64`) -rust-lang#126424 ( Also sort `crt-static` in `--print target-features` output) -rust-lang#126428 (Polish `std::path::absolute` documentation.) -rust-lang#126429 (Add `f16` and `f128` const eval for binary and unary operationations) -rust-lang#126448 (End support for Python 3.8 in tidy) -rust-lang#126488 (Use `std::path::absolute` in bootstrap) -rust-lang#126511 (.mailmap: Associate both my work and my private email with me)r? `@ghost``@rustbot` modify labels: rollup
@borsbors merged commitd00e71e intorust-lang:masterJun 15, 2024
@rustbotrustbot added this to the1.81.0 milestoneJun 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
Rollup merge ofrust-lang#126488 - ChrisDenton:absolute, r=albertlarsan68Use `std::path::absolute` in bootstrap`std::path::absolute` is now stable in 1.79 so we can get rid of the copy-pasted version.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@albertlarsan68albertlarsan68

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ChrisDenton@rustbot@albertlarsan68@bors@rust-log-analyzer
[8]ページ先頭
©2009-2025 Movatter.jp