- Notifications
You must be signed in to change notification settings - Fork14.1k
Polishstd::path::absolute documentation.#126428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
rustbot commentedJun 13, 2024
This comment has been minimized.
This comment has been minimized.
Member
lqd commentedJun 13, 2024
(cc#126430 on that last spurious PR CI failure) |
Member
jhpratt commentedJun 14, 2024
@bors delegate+
|
Collaborator
bors commentedJun 14, 2024
This comment has been minimized.
This comment has been minimized.
Member
ChrisDenton commentedJun 14, 2024
@kpreid, could you rebase and force push just to get CI running properly? |
These changes bring it closer to other standard library documentationand, in particular, `std::fs::canonicalize`, which it will often becompared with.* Add `# Platform-specific behavior` section, with content moved from Examples section.* Create `# Errors` section.* Phrase error description to allow future platforms to have new syntactic errors, rather than only emptiness.* Add missing commas.* Indent example code 4 spaces.
ContributorAuthor
kpreid commentedJun 14, 2024
Collaborator
bors commentedJun 14, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJun 15, 2024
Polish `std::path::absolute` documentation.These changes bring it closer to other standard library documentation and, in particular, `std::fs::canonicalize`, which it will often be compared with.* Add `# Platform-specific behavior` section, with content moved from Examples section.* Create `# Errors` section.* Phrase error description to allow future platforms to have new syntactic errors, rather than only emptiness.* Add missing commas.* Indent example code 4 spaces.
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
…iaskrgrRollup of 10 pull requestsSuccessful merges: -rust-lang#125829 (rustc_span: Add conveniences for working with span formats) -rust-lang#126279 (Migrate `inaccessible-temp-dir`, `output-with-hyphens` and `issue-10971-temps-dir` `run-make` tests to `rmake`) -rust-lang#126361 (Unify intrinsics body handling in StableMIR) -rust-lang#126417 (Add `f16` and `f128` inline ASM support for `x86` and `x86-64`) -rust-lang#126424 ( Also sort `crt-static` in `--print target-features` output) -rust-lang#126428 (Polish `std::path::absolute` documentation.) -rust-lang#126429 (Add `f16` and `f128` const eval for binary and unary operationations) -rust-lang#126448 (End support for Python 3.8 in tidy) -rust-lang#126488 (Use `std::path::absolute` in bootstrap) -rust-lang#126511 (.mailmap: Associate both my work and my private email with me)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
…iaskrgrRollup of 9 pull requestsSuccessful merges: -rust-lang#125829 (rustc_span: Add conveniences for working with span formats) -rust-lang#126361 (Unify intrinsics body handling in StableMIR) -rust-lang#126417 (Add `f16` and `f128` inline ASM support for `x86` and `x86-64`) -rust-lang#126424 ( Also sort `crt-static` in `--print target-features` output) -rust-lang#126428 (Polish `std::path::absolute` documentation.) -rust-lang#126429 (Add `f16` and `f128` const eval for binary and unary operationations) -rust-lang#126448 (End support for Python 3.8 in tidy) -rust-lang#126488 (Use `std::path::absolute` in bootstrap) -rust-lang#126511 (.mailmap: Associate both my work and my private email with me)r? `@ghost``@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
Rollup merge ofrust-lang#126428 - kpreid:absolute, r=jhprattPolish `std::path::absolute` documentation.These changes bring it closer to other standard library documentation and, in particular, `std::fs::canonicalize`, which it will often be compared with.* Add `# Platform-specific behavior` section, with content moved from Examples section.* Create `# Errors` section.* Phrase error description to allow future platforms to have new syntactic errors, rather than only emptiness.* Add missing commas.* Indent example code 4 spaces.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libsRelevant to the library team, which will review and decide on the PR/issue.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes bring it closer to other standard library documentation and, in particular,
std::fs::canonicalize, which it will often be compared with.# Platform-specific behaviorsection, with content moved from Examples section.# Errorssection.