- Notifications
You must be signed in to change notification settings - Fork14.1k
Addf16 andf128 inline ASM support forx86 andx86-64#126417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Collaborator
rustbot commentedJun 13, 2024
rustbot has assigned@petrochenkov. Use |
Contributor
petrochenkov commentedJun 13, 2024
r?@Amanieu |
Contributor
tgross35 commentedJun 13, 2024
Thanks, there is some overlap here with#126070 |
| Self::xmm_reg =>types!{ | ||
| sse:I32,I64,F32,F64, | ||
| VecI8(16),VecI16(8),VecI32(4),VecI64(2),VecF32(4),VecF64(2); | ||
| sse:I32,I64,F16,F32,F64,F128, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would hold back on addingf128 as an allowed input type since there aren't any instructions that actually support that type.
But for f16 this seems fine.
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While there aren't any instructions that takef128 as an operand,f128 is passed and returned in XMM registers as part of the x86-64System V C ABI so seems worth including.
Member
Amanieu commentedJun 14, 2024
@bors r+ |
Collaborator
bors commentedJun 14, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestJun 15, 2024
…r=AmanieuAdd `f16` and `f128` inline ASM support for `x86` and `x86-64`This PR adds `f16` and `f128` input and output support to inline ASM on `x86` and `x86-64`. `f16` vector sizes are taken from [here](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html).Relevant issue:rust-lang#125398Tracking issue:rust-lang#116909`@rustbot` label +F-f16_and_f128
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
…iaskrgrRollup of 10 pull requestsSuccessful merges: -rust-lang#125829 (rustc_span: Add conveniences for working with span formats) -rust-lang#126279 (Migrate `inaccessible-temp-dir`, `output-with-hyphens` and `issue-10971-temps-dir` `run-make` tests to `rmake`) -rust-lang#126361 (Unify intrinsics body handling in StableMIR) -rust-lang#126417 (Add `f16` and `f128` inline ASM support for `x86` and `x86-64`) -rust-lang#126424 ( Also sort `crt-static` in `--print target-features` output) -rust-lang#126428 (Polish `std::path::absolute` documentation.) -rust-lang#126429 (Add `f16` and `f128` const eval for binary and unary operationations) -rust-lang#126448 (End support for Python 3.8 in tidy) -rust-lang#126488 (Use `std::path::absolute` in bootstrap) -rust-lang#126511 (.mailmap: Associate both my work and my private email with me)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
…iaskrgrRollup of 9 pull requestsSuccessful merges: -rust-lang#125829 (rustc_span: Add conveniences for working with span formats) -rust-lang#126361 (Unify intrinsics body handling in StableMIR) -rust-lang#126417 (Add `f16` and `f128` inline ASM support for `x86` and `x86-64`) -rust-lang#126424 ( Also sort `crt-static` in `--print target-features` output) -rust-lang#126428 (Polish `std::path::absolute` documentation.) -rust-lang#126429 (Add `f16` and `f128` const eval for binary and unary operationations) -rust-lang#126448 (End support for Python 3.8 in tidy) -rust-lang#126488 (Use `std::path::absolute` in bootstrap) -rust-lang#126511 (.mailmap: Associate both my work and my private email with me)r? `@ghost``@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestJun 15, 2024
Rollup merge ofrust-lang#126417 - beetrees:f16-f128-inline-asm-x86, r=AmanieuAdd `f16` and `f128` inline ASM support for `x86` and `x86-64`This PR adds `f16` and `f128` input and output support to inline ASM on `x86` and `x86-64`. `f16` vector sizes are taken from [here](https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html).Relevant issue:rust-lang#125398Tracking issue:rust-lang#116909``@rustbot`` label +F-f16_and_f128
This was referencedJun 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]` S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
f16andf128input and output support to inline ASM onx86andx86-64.f16vector sizes are taken fromhere.Relevant issue:#125398
Tracking issue:#116909
@rustbot label +F-f16_and_f128