- Notifications
You must be signed in to change notification settings - Fork14.1k
Makebody_owned_by return theBody instead of just theBodyId#125711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Almost all callers want this anyway, and now we can use it to also return fed bodies
Collaborator
rustbot commentedMay 29, 2024
rustbot has assigned@Nadrieril. Use |
Collaborator
rustbot commentedMay 29, 2024
Member
Nadrieril commentedMay 29, 2024
LGTM @bors r+ |
Collaborator
bors commentedMay 29, 2024
fmease added a commit to fmease/rust that referenced this pull requestMay 30, 2024
Make `body_owned_by` return the `Body` instead of just the `BodyId`fixesrust-lang#125677Almost all `body_owned_by` callers immediately called `body`, too, so just return `Body` directly.This makes the inline-const query feeding more robust, as all calls to `body_owned_by` will now yield a body for inline consts, too.I have not yet figured out a good way to make `tcx.hir().body()` return an inline-const body, but that can be done as a follow-up
bors added a commit to rust-lang-ci/rust that referenced this pull requestMay 30, 2024
Rollup of 6 pull requestsSuccessful merges: -rust-lang#124636 (Make `std::env::{set_var, remove_var}` unsafe in edition 2024) -rust-lang#125342 (Document platform-specifics for `Read` and `Write` of `File`) -rust-lang#125671 (Do not equate `Const`'s ty in `super_combine_const`) -rust-lang#125711 (Make `body_owned_by` return the `Body` instead of just the `BodyId`) -rust-lang#125745 (Bump the stage0 compiler to beta.7 (2024-05-26)) -rust-lang#125753 (compiletest: Unify `cmd2procres` with `run_command_to_procres`)r? `@ghost``@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull requestMay 30, 2024
Rollup of 6 pull requestsSuccessful merges: -rust-lang#124636 (Make `std::env::{set_var, remove_var}` unsafe in edition 2024) -rust-lang#125342 (Document platform-specifics for `Read` and `Write` of `File`) -rust-lang#125671 (Do not equate `Const`'s ty in `super_combine_const`) -rust-lang#125711 (Make `body_owned_by` return the `Body` instead of just the `BodyId`) -rust-lang#125745 (Bump the stage0 compiler to beta.7 (2024-05-26)) -rust-lang#125753 (compiletest: Unify `cmd2procres` with `run_command_to_procres`)r? `@ghost``@rustbot` modify labels: rollup
Collaborator
bors commentedMay 30, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestMay 30, 2024
Make `body_owned_by` return the `Body` instead of just the `BodyId`fixesrust-lang#125677Almost all `body_owned_by` callers immediately called `body`, too, so just return `Body` directly.This makes the inline-const query feeding more robust, as all calls to `body_owned_by` will now yield a body for inline consts, too.I have not yet figured out a good way to make `tcx.hir().body()` return an inline-const body, but that can be done as a follow-up
Collaborator
bors commentedMay 30, 2024
☀️ Test successful -checks-actions |
bors added a commit to rust-lang-ci/rust that referenced this pull requestMay 30, 2024
…iaskrgrRollup of 7 pull requestsSuccessful merges: -rust-lang#125342 (Document platform-specifics for `Read` and `Write` of `File`) -rust-lang#125711 (Make `body_owned_by` return the `Body` instead of just the `BodyId`) -rust-lang#125739 (drop_in_place: weaken the claim of equivalence with drop(ptr.read())) -rust-lang#125745 (Bump the stage0 compiler to beta.7 (2024-05-26)) -rust-lang#125746 (Fix copy-paste error in `Duration::from_weeks` panic message.) -rust-lang#125753 (compiletest: Unify `cmd2procres` with `run_command_to_procres`) -rust-lang#125754 (coverage: Rename MC/DC `conditions_num` to `num_conditions`)r? `@ghost``@rustbot` modify labels: rollup
Collaborator
rust-timer commentedMay 30, 2024
Finished benchmarking commit (d43930d):comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 667.227s -> 665.728s (-0.22%) |
flip1995 pushed a commit to flip1995/rust that referenced this pull requestJun 13, 2024
Make `body_owned_by` return the `Body` instead of just the `BodyId`fixesrust-lang#125677Almost all `body_owned_by` callers immediately called `body`, too, so just return `Body` directly.This makes the inline-const query feeding more robust, as all calls to `body_owned_by` will now yield a body for inline consts, too.I have not yet figured out a good way to make `tcx.hir().body()` return an inline-const body, but that can be done as a follow-up
flip1995 pushed a commit to flip1995/rust that referenced this pull requestJun 13, 2024
Make `body_owned_by` return the `Body` instead of just the `BodyId`fixesrust-lang#125677Almost all `body_owned_by` callers immediately called `body`, too, so just return `Body` directly.This makes the inline-const query feeding more robust, as all calls to `body_owned_by` will now yield a body for inline consts, too.I have not yet figured out a good way to make `tcx.hir().body()` return an inline-const body, but that can be done as a follow-up
flip1995 pushed a commit to flip1995/rust that referenced this pull requestJun 13, 2024
…iaskrgrRollup of 7 pull requestsSuccessful merges: -rust-lang#125342 (Document platform-specifics for `Read` and `Write` of `File`) -rust-lang#125711 (Make `body_owned_by` return the `Body` instead of just the `BodyId`) -rust-lang#125739 (drop_in_place: weaken the claim of equivalence with drop(ptr.read())) -rust-lang#125745 (Bump the stage0 compiler to beta.7 (2024-05-26)) -rust-lang#125746 (Fix copy-paste error in `Duration::from_weeks` panic message.) -rust-lang#125753 (compiletest: Unify `cmd2procres` with `run_command_to_procres`) -rust-lang#125754 (coverage: Rename MC/DC `conditions_num` to `num_conditions`)r? `@ghost``@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
A-rustdoc-jsonArea: Rustdoc JSON backend merged-by-borsThis PR was explicitly merged by bors. S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#125677
Almost all
body_owned_bycallers immediately calledbody, too, so just returnBodydirectly.This makes the inline-const query feeding more robust, as all calls to
body_owned_bywill now yield a body for inline consts, too.I have not yet figured out a good way to make
tcx.hir().body()return an inline-const body, but that can be done as a follow-up