Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add v0 symbol mangling forf16 andf128#123816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bors merged 2 commits intorust-lang:masterfromtgross35:f16-f128-mangling
May 14, 2024

Conversation

@tgross35
Copy link
Contributor

As discussed at#122106, use the crate encoding to represent new primitives.

@rustbot
Copy link
Collaborator

r?@lcnr

rustbot has assigned@lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

User? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. labelsApr 11, 2024
@tgross35
Copy link
ContributorAuthor

tgross35 commentedApr 11, 2024•
edited
Loading

r?@michaelwoerister

This should probably have a test, what does this need to look like?

@rustbot label +F-f16_and_f128

@wargio
Copy link

@tgross35
Copy link
ContributorAuthor

tgross35 commentedApr 12, 2024•
edited
Loading

That is awesome, thanks for being on the cutting edge of Rust demangling. It really is helpful to know that these changes work.

@michaelwoerister
Copy link
Member

Thanks for opening the PR! Yes, tests will be needed. There are UI tests inhttps://github.com/rust-lang/rust/blob/master/tests/ui/symbol-names. I'm a bit surprised thatthe test case for simple types does not test seem to test v0 mangling at all. It would be best to fix that. Let me know if you get stuck, then I can look into updating the existing tests in a separate PR.

tgross35 reacted with thumbs up emoji

@tgross35tgross35force-pushed thef16-f128-mangling branch 2 times, most recently fromfc914fa to8e70f82CompareApril 12, 2024 18:13
@tgross35
Copy link
ContributorAuthor

I added the v0 checks to the types test you linked, and addedf16 andf128. I must be doing something with the ERROR checks though, I can't seem to get the attributes to check correctly even though the stderr files look alright.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@michaelwoerister
Copy link
Member

It seems that the test case parser cannot deal with- inside revision names in error annotations. I suggest we fix this asap so that others don't waste time debugging this again. Updating this regular expression in compiletest should do the trick:

Lazy::new(||Regex::new(r"//(?:\[(?P<revs>[\w,]+)])?~(?P<adjust>\||\^*)").unwrap());

That needs to be(?P<revs>[\w\-,]+) because\w apparently does not cover-.

@tgross35
Copy link
ContributorAuthor

Missed that comment, thanks! Really had me confused.

Opened#124137 to fix this

michaelwoerister reacted with heart emoji

@michaelwoerister
Copy link
Member

@tgross35, if you want to make progress with this PR, independently of what the fix for compiletest turns out to be, I'd suggest to just rename theverbose-legacy revision to something that currently works.

@tgross35
Copy link
ContributorAuthor

That's my plan if#124137 doesn't land before I circle back to this. Do the changes look fine, assuming I get the tests to actually pass? I probably also have to changeERROR demangling(<a[HASH]::b::Type<bool>>) toERROR ::b::Type<bool>>) since normalization doesn't get passed to directives, unfortunately

@rust-log-analyzer

This comment has been minimized.

@tgross35
Copy link
ContributorAuthor

Ah sorry this slipped my mind, thanks for the poke.

@rustbot ready

michaelwoerister reacted with heart emoji

@rustbotrustbot added S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author. labelsMay 14, 2024
@michaelwoerister
Copy link
Member

Thank you,@tgross35!

@bors r+

tgross35 reacted with hooray emoji

@bors
Copy link
Collaborator

📌 Commit792a9bd has been approved bymichaelwoerister

It is now in thequeue for this repository.

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelsMay 14, 2024
@bors
Copy link
Collaborator

⌛ Testing commit792a9bd with mergebdfd941...

@bors
Copy link
Collaborator

☀️ Test successful -checks-actions
Approved by: michaelwoerister
Pushingbdfd941 to master...

@borsbors added the merged-by-borsThis PR was explicitly merged by bors. labelMay 14, 2024
@borsbors merged commitbdfd941 intorust-lang:masterMay 14, 2024
@rustbotrustbot added this to the1.80.0 milestoneMay 14, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bdfd941):comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.4%[-0.5%, -0.2%]2
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.4%[-0.5%, -0.2%]2

Max RSS (memory usage)

Results (secondary 4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		4.3%[4.3%, 4.3%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.763s -> 676.581s (0.12%)
Artifact size: 315.97 MiB -> 315.96 MiB (-0.00%)

@tgross35tgross35 deleted the f16-f128-mangling branchMay 14, 2024 18:17
@tgross35
Copy link
ContributorAuthor

@rustbot label +beta-nominated

Nominating the first commit of this PR (809b84e) for beta backport as not having it in stage0 is blocking updates to compiler-builtins#125016. Only the first commit since the second adds tests that depend on a rustc-demangle update (part of#124213, which is much larger).

Unsure what the policy is for this kind of less essential update soI asked on Zulip. Risk is qutie low so figure it doesn't hurt to ask.

@rustbotrustbot added the beta-nominatedNominated for backporting to the compiler in the beta channel. labelMay 16, 2024
@apiraino
Copy link
Contributor

Beta backport approved as per compiler teamon Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

@rustbotrustbot added the beta-acceptedAccepted for backporting to the compiler in the beta channel. labelMay 24, 2024
@cuvipercuviper mentioned this pull requestMay 25, 2024
@cuvipercuviper modified the milestones:1.80.0,1.79.0May 25, 2024
@cuvipercuviper removed the beta-nominatedNominated for backporting to the compiler in the beta channel. labelMay 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull requestMay 25, 2024
[beta] backports- Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)`rust-lang#125252- Add v0 symbol mangling for `f16` and `f128`rust-lang#123816- Only make GAT ambiguous in `match_projection_projections` considering shallow resolvabilityrust-lang#125214- Update to LLVM 18.1.6rust-lang#125288r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull requestMay 25, 2024
[beta] backports- Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)`rust-lang#125252- Add v0 symbol mangling for `f16` and `f128`rust-lang#123816- Only make GAT ambiguous in `match_projection_projections` considering shallow resolvabilityrust-lang#125214- Update to LLVM 18.1.6rust-lang#125288r? cuviper
celinval pushed a commit to celinval/rust-dev that referenced this pull requestJun 4, 2024
Update Rust toolchain from nightly-2024-05-14 to nightly-2024-05-15without any other source changes.This is an automatically generated pull request. If any of the CI checksfail, manual intervention is required. In such a case, review thechanges athttps://github.com/rust-lang/rust fromrust-lang@ab14f94up torust-lang@8387315.The log for this commit range is:rust-lang@8387315ab3 Auto merge ofrust-lang#125125 - lovesegfault:opt-dist-specify-rustc-perf, r=Mark-Simulacrumrust-lang@c3c9783de2feat(tools/opt-dist): allow local builds to specify a rustc-perfcheckoutrust-lang@ac385a5af6 Auto merge ofrust-lang#125120 - compiler-errors:rollup-mnjybwv, r=compiler-errorsrust-lang@31016d5879 Rollup merge ofrust-lang#125118 - GuillaumeGomez:cleanup-run-make, r=jieyouxurust-lang@d59f430eec Rollup merge ofrust-lang#125100 - compiler-errors:faster, r=nnethercoterust-lang@712e7c37f7 Rollup merge ofrust-lang#125088 - compiler-errors:uplift-alias-ty, r=lcnrrust-lang@8c64acdbdc Rollup merge ofrust-lang#125080 - bvanjoi:fix-124946, r=nnethercoterust-lang@844c7e826e Rollup merge ofrust-lang#125047 - Oneirical:test5, r=jieyouxurust-lang@0458d8a53b Rollup merge ofrust-lang#124844 - compiler-errors:shadow-probe, r=lcnrrust-lang@36287830a2 Rollup merge ofrust-lang#119838 - joshtriplett:style-guide-binop-indent, r=compiler-errorsrust-lang@ade33b02f2 only find segs chainfor missing methods when no available candidatesrust-lang@bdfd941f4d Auto merge ofrust-lang#123816 - tgross35:f16-f128-mangling, r=michaelwoeristerrust-lang@f97d915173 Use new utilityfunctions/methods in run-make testsrust-lang@792a9bdd4b Enable v0 manglingtests and add checks for `f16`/`f128`rust-lang@809b84edba Add v0 symbolmangling for `f16` and `f128`rust-lang@31026b7fe3 Auto merge ofrust-lang#125023 - morr0ne:linux-none-target, r=Nilstriebrust-lang@68407f9049 fix typo inx86_64-unknown-linux-none docsrust-lang@c45e831d8f Auto merge ofrust-lang#124228 - compiler-errors:lint-overcaptures, r=oli-obkrust-lang@58426f4a5b Auto merge ofrust-lang#125026 - Oneirical:clink-tests, r=jieyouxurust-lang@e098eb14ae Wording improvementrust-lang@e2d9c0d938 Fix missing wordrust-lang@57c32a193f style-guide: Whenbreaking binops handle multi-line first operand betterrust-lang@dbd2ca6478 Use a proper probefor shadowing implrust-lang@052de1da4f And finally addtestsrust-lang@1529c661e4 Warn againstredundant use<...>rust-lang@f3fb727b08 Don't suggest usinguse<> syntax to capture APITsrust-lang@6afe1352d9 Suggest adding use<>syntaxrust-lang@554becc180 Add some commentingrust-lang@d57e57ca1f Implement initialIMPL_TRAIT_OVERCAPTURES lintrust-lang@8f97a2588c Add test to makesure suggestions are still quickrust-lang@fba5f44bd8 Auto merge ofrust-lang#125098 - jhpratt:rollup-2qm4gga, r=jhprattrust-lang@45b50d303c lto function,static_library call, renamerust-lang@9f8cdb286e Remove to_termrust-lang@1ad28a6f53 Uplift AliasTyrust-lang@812f89728a fix fmtrust-lang@2e4c90c3f7 Don't dopost-method-probe error reporting steps if we're in a suggestionrust-lang@32d74f1800 Rollup merge ofrust-lang#125090 - erickt:bump-fuchsia, r=tmandryrust-lang@209703af85 Rollup merge ofrust-lang#125072 - Darksonn:pin-dyn-dispatch-sound, r=jhprattrust-lang@18d9c039bb Rollup merge ofrust-lang#124997 - gurry:124848-ice-should-be-sized, r=Nadrierilrust-lang@74a78af0e2 Rollup merge ofrust-lang#116675 - joshlf:patch-10, r=scottmcmrust-lang@9105c57b7f Auto merge ofrust-lang#124256 - nnethercote:rm-NtIdent-NtLifetime, r=petrochenkovrust-lang@34582118af Auto merge ofrust-lang#125076 - compiler-errors:alias-term, r=lcnrrust-lang@95e519ecbf Remove `NtIdent` and`NtLifetime`.rust-lang@fa84018c2e Apply nitsrust-lang@58ee9192e0 Migrate fuchsia docsfrom `pm` to `ffx`rust-lang@293b5cb1ca [ptr] Documentmaximum allocation sizerust-lang@3bcdf3058e split out AliasTy ->AliasTermrust-lang@b3a78c1d09 Add test for dynamicdispatch + Pin::new soundnessrust-lang@9a63a42cb7 Remove a `Span` from`TokenKind::Interpolated`.rust-lang@71fd2cf5b4 fix function calland importrust-lang@a1b5ea0cc2 make tidy happyrust-lang@f2de5fb2ae rewrite issue-14500to rmakerust-lang@a6f237ca85 docs: fix typo inplatform-support docsrust-lang@923cdb35aa test: Add assemblytests for x86_64-unknown-linux-none targetrust-lang@10c358f111 Make tidy happyrust-lang@e37d2989c1 remove trailingwhitespacerust-lang@a2e7e79a13 Portc-link-to-rust-va-list-fn to Rustrust-lang@9cf080099d docs: Documentx86_64-unknown-linux-none targetrust-lang@a3ef01b1fc Addx86_64-unknown-linux-none targetrust-lang@fb619ec208 FIx ICE whilecasting a type with errorCo-authored-by: tautschnig <1144736+tautschnig@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@michaelwoeristermichaelwoeristermichaelwoerister left review comments

Reviewers whose approvals may not affect merge requirements

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]`merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@wargio@michaelwoerister@rust-log-analyzer@bors@rust-timer@apiraino@cuviper@lcnr
[8]ページ先頭
©2009-2025 Movatter.jp