Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

f16 andf128 step 2: intrinsics#121841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bors merged 5 commits intorust-lang:masterfromtgross35:f16-f128-step2-intrinsics
Mar 3, 2024

Conversation

@tgross35
Copy link
Contributor

@tgross35tgross35 commentedMar 1, 2024
edited
Loading

Continuation of#121728, another portion of#114607.

This PR addsf16 andf128 intrinsics, and hooks them up to both HIR and LLVM. This is all still unexposed to the frontend, which will probably be the next step. Also update itanium mangling per@rcvalle's inhttps://github.com/rust-lang/rust/pull/121728/files#r1506570300, and fix a typo from step 1.

Once these types are usable in code, I will add the codegen tests from#114607 (codegen is passing on that branch)

This does add moreunimplemented!s to Clippy, but I still don't think we can do better until library support is added.

Tracking issue:#116909

r?@compiler-errors
cc@Nilstrieb
@rustbot label +T-compiler +F-f16_and_f128

Luracasmus and fee1-dead reacted with thumbs up emojiLuracasmus reacted with rocket emoji
@rustbotrustbot added S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. T-compilerRelevant to the compiler team, which will review and decide on the PR/issue. T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver) labelsMar 1, 2024
@rustbot
Copy link
Collaborator

Some changes occurred in exhaustiveness checking

cc@Nadrieril

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_gcc

cc@antoyo,@GuillaumeGomez

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in src/librustdoc/clean/types.rs

cc@camelid

Some changes occurred in compiler/rustc_codegen_cranelift

cc@bjorn3

Some changes occurred in match checking

cc@Nadrieril

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbotrustbot added the F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]` labelMar 1, 2024
@tgross35tgross35force-pushed thef16-f128-step2-intrinsics branch frome4816c3 to5f14869CompareMarch 1, 2024 09:42
@tgross35
Copy link
ContributorAuthor

Sorry for the noise, accidentally included my commits from#121728. Most of the mentions in that comment are unchanged in this PR.

@tgross35tgross35force-pushed thef16-f128-step2-intrinsics branch 2 times, most recently frome39b853 to78c618eCompareMarch 1, 2024 09:50
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@compiler-errorscompiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One nit, also needs CI to pass. r=me after.

@rustbotrustbot added S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelsMar 1, 2024
@tgross35tgross35force-pushed thef16-f128-step2-intrinsics branch from78c618e tof375424CompareMarch 1, 2024 17:39
@rustbotrustbot added S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author. labelsMar 1, 2024
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commentedMar 1, 2024

📌 Commitf375424 has been approved bycompiler-errors

It is now in thequeue for this repository.

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelsMar 1, 2024
@compiler-errors
Copy link
Member

Actually just fix both of these issues now, there's no rush to get this PR merged.

@bors r-

@borsbors added S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. labelsMar 1, 2024
@tgross35tgross35force-pushed thef16-f128-step2-intrinsics branch fromf375424 to01755e3CompareMarch 1, 2024 18:59
@tgross35
Copy link
ContributorAuthor

Easy enough, fixed both things

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commentedMar 1, 2024

📌 Commit01755e3 has been approved bycompiler-errors

It is now in thequeue for this repository.

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author. labelsMar 1, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull requestMar 2, 2024
Rollup of 5 pull requestsSuccessful merges: -rust-lang#120761 (Add initial support for DataFlowSanitizer) -rust-lang#121622 (Preserve same vtable pointer when cloning raw waker, to fix Waker::will_wake) -rust-lang#121716 (match lowering: Lower bindings in a predictable order) -rust-lang#121731 (Now that inlining, mir validation and const eval all use reveal-all, we won't be constraining hidden types here anymore) -rust-lang#121841 (`f16` and `f128` step 2: intrinsics)r? `@ghost``@rustbot` modify labels: rollup
@borsbors merged commit4c65eef intorust-lang:masterMar 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull requestMar 3, 2024
Rollup merge ofrust-lang#121841 - tgross35:f16-f128-step2-intrinsics, r=compiler-errors`f16` and `f128` step 2: intrinsicsContinuation ofrust-lang#121728, another portion ofrust-lang#114607.This PR adds `f16` and `f128` intrinsics, and hooks them up to both HIR and LLVM. This is all still unexposed to the frontend, which will probably be the next step. Also update itanium mangling per `@rcvalle's` inhttps://github.com/rust-lang/rust/pull/121728/files#r1506570300, and fix a typo from step 1.Once these types are usable in code, I will add the codegen tests fromrust-lang#114607 (codegen is passing on that branch)This does add more `unimplemented!`s to Clippy, but I still don't think we can do better until library support is added.r? `@compiler-errors`cc `@Nilstrieb``@rustbot` label +T-compiler +F-f16_and_f128
@rustbotrustbot added this to the1.78.0 milestoneMar 3, 2024
@tgross35tgross35 deleted the f16-f128-step2-intrinsics branchMarch 3, 2024 01:28
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestMar 6, 2024
…te, r=compiler-errors`f16` and `f128` step 3: compiler support & feature gateContinuation ofrust-lang#121841, another portion ofrust-lang#114607This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed).If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes.Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step.Tracking issue:rust-lang#116909r? `@compiler-errors`cc `@Nilstrieb``@rustbot` label +F-f16_and_f128
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestMar 6, 2024
…te, r=compiler-errors`f16` and `f128` step 3: compiler support & feature gateContinuation ofrust-lang#121841, another portion ofrust-lang#114607This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed).If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes.Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step.Tracking issue:rust-lang#116909r? ``@compiler-errors``cc ``@Nilstrieb````@rustbot`` label +F-f16_and_f128
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull requestMar 6, 2024
…te, r=compiler-errors`f16` and `f128` step 3: compiler support & feature gateContinuation ofrust-lang#121841, another portion ofrust-lang#114607This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed).If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes.Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step.Tracking issue:rust-lang#116909r? ```@compiler-errors```cc ```@Nilstrieb``````@rustbot``` label +F-f16_and_f128
flip1995 pushed a commit to flip1995/rust that referenced this pull requestMar 7, 2024
…, r=compiler-errors`f16` and `f128` step 2: intrinsicsContinuation ofrust-lang#121728, another portion ofrust-lang#114607.This PR adds `f16` and `f128` intrinsics, and hooks them up to both HIR and LLVM. This is all still unexposed to the frontend, which will probably be the next step. Also update itanium mangling per `@rcvalle's` inhttps://github.com/rust-lang/rust/pull/121728/files#r1506570300, and fix a typo from step 1.Once these types are usable in code, I will add the codegen tests fromrust-lang#114607 (codegen is passing on that branch)This does add more `unimplemented!`s to Clippy, but I still don't think we can do better until library support is added.r? `@compiler-errors`cc `@Nilstrieb``@rustbot` label +T-compiler +F-f16_and_f128
bors added a commit to rust-lang-ci/rust that referenced this pull requestMar 15, 2024
…, r=compiler-errors,petrochenkov`f16` and `f128` step 3: compiler support & feature gateContinuation ofrust-lang#121841, another portion ofrust-lang#114607This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed).If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes.Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step.Tracking issue:rust-lang#116909r? `@compiler-errors`cc `@Nilstrieb``@rustbot` label +F-f16_and_f128
bors added a commit to rust-lang-ci/rust that referenced this pull requestMar 16, 2024
…, r=compiler-errors,petrochenkov`f16` and `f128` step 3: compiler support & feature gateContinuation ofrust-lang#121841, another portion ofrust-lang#114607This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed).If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes.Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step.Tracking issue:rust-lang#116909r? `@compiler-errors`cc `@Nilstrieb``@rustbot` label +F-f16_and_f128
github-actionsbot pushed a commit to rust-lang/miri that referenced this pull requestMar 17, 2024
…ler-errors,petrochenkov`f16` and `f128` step 3: compiler support & feature gateContinuation ofrust-lang/rust#121841, another portion ofrust-lang/rust#114607This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed).If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes.Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step.Tracking issue:rust-lang/rust#116909r? `@compiler-errors`cc `@Nilstrieb``@rustbot` label +F-f16_and_f128
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rcvallercvallercvalle left review comments

@compiler-errorscompiler-errorscompiler-errors approved these changes

Assignees

@compiler-errorscompiler-errors

Labels

F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.78.0

Development

Successfully merging this pull request may close these issues.

6 participants

@tgross35@rustbot@rust-log-analyzer@compiler-errors@bors@rcvalle

[8]ページ先頭

©2009-2025 Movatter.jp