NotificationsYou must be signed in to change notification settings
Fork13.9k
Star108k

rustdoc: avoid allocating strings primitive link printing#117007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bors merged 1 commit intorust-lang:masterfromnotriddle:notriddle/format-links-with-display

Oct 22, 2023

Merged

rustdoc: avoid allocating strings primitive link printing#117007

bors merged 1 commit intorust-lang:masterfromnotriddle:notriddle/format-links-with-display

Oct 22, 2023

Conversation

Copy link

Contributor

notriddle commentedOct 21, 2023

This is aimed at hitting the allocator less in a function that gets called a lot.

rustbot assignedjsha

Oct 21, 2023

Copy link

Collaborator

rustbot commentedOct 21, 2023

r?@jsha

(rustbot has picked a reviewer for you, use r? to override)

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue. labels

Oct 21, 2023

Copy link

ContributorAuthor

notriddle commentedOct 21, 2023

@bors try@rust-timer queue

This comment has been minimized.

rustbot added the S-waiting-on-perfStatus: Waiting on a perf run to be completed. label

Oct 21, 2023

Copy link

Collaborator

bors commentedOct 21, 2023

☀️ Try build successful -checks-actions
Build commit:4d4d8fd (4d4d8fd42aa29dafbf0f9738cc35dd152d19f6bd)

This comment has been minimized.

Copy link

Collaborator

rust-timer commentedOct 21, 2023

Finished benchmarking commit (4d4d8fd):comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.871s -> 630.45s (-0.22%)
Artifact size: 304.05 MiB -> 304.04 MiB (-0.01%)

rustbot removed the S-waiting-on-perfStatus: Waiting on a perf run to be completed. label

Oct 21, 2023

bugadani reviewed

Oct 21, 2023

View reviewed changes

src/librustdoc/html/format.rs Outdated

		primitive_link(
		f,
		PrimitiveType::Tuple,
		&display_fn(\|f\|write!(f,"({name},)")),

Copy link

Contributor

bugadaniOct 21, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wouldn't this pattern (single write inside a display_fn) be better as aformat_args!() instead? I wonder what implications that would have.

Copy link

ContributorAuthor

notriddleOct 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very good point.

rustdoc: avoid allocating strings primitive link printing

4851cc9

This is aimed at hitting the allocator less in a function thatgets called a lot.

notriddle force-pushed thenotriddle/format-links-with-display branch from7af1b2f to4851cc9Compare

October 21, 2023 14:49

notriddle changed the title~~[perf run] rustdoc: avoid allocating strings primitive link printing~~rustdoc: avoid allocating strings primitive link printing

Oct 21, 2023

notriddle marked this pull request as ready for review

October 21, 2023 14:49

Copy link

ContributorAuthor

notriddle commentedOct 21, 2023

Try it with@bugadani's suggestion of format_args

@bors try@rust-timer queue

This comment has been minimized.

rustbot added the S-waiting-on-perfStatus: Waiting on a perf run to be completed. label

Oct 21, 2023

Copy link

Collaborator

bors commentedOct 21, 2023

⌛ Trying commit4851cc9 with merge7eb211f...

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 21, 2023

Auto merge ofrust-lang#117007- notriddle:notriddle/format-links-wit…

7eb211f

…h-display, r=<try>rustdoc: avoid allocating strings primitive link printingThis is aimed at hitting the allocator less in a function that gets called a lot.

Copy link

Collaborator

bors commentedOct 21, 2023

☀️ Try build successful -checks-actions
Build commit:7eb211f (7eb211f30a7b293ef7a409ae337c3ba6507d579c)

This comment has been minimized.

Copy link

Collaborator

rust-timer commentedOct 21, 2023

Finished benchmarking commit (7eb211f):comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with@rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.8%	[3.8%, 3.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.8%	[3.8%, 3.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.62s -> 631.227s (-0.06%)
Artifact size: 301.95 MiB -> 301.96 MiB (0.00%)

rustbot added perf-regressionPerformance regression. and removed S-waiting-on-perfStatus: Waiting on a perf run to be completed. labels

Oct 21, 2023

Copy link

ContributorAuthor

notriddle commentedOct 21, 2023

The “regression” isn’t a doc build.

notriddle added the perf-regression-triagedThe performance regression has been triaged. label

Oct 22, 2023

Copy link

Member

fmease commentedOct 22, 2023•
edited
Loading

Hmm, that's odd. I didn't expect to see perf regressions in LLVM codegen, that doesn't make much sense to me for this rustdoc PR. This has to be spurious, right?

#116885 had similar regressions inLLVM_{module_codegen_emit_obj,{module,lto}_optimize,passes},finish_ongoing_codegen (perf result sample). They might be real but they could also hint at faulty perf metrics of some sorts? I mean ifrustdoc itself was harder to optimize withformat_args, I would understand. However, this is an alleged regression in codegen'ingsyn.

Thanks for improving thedoc times!
r? fmease@bors r+

Copy link

Collaborator

bors commentedOct 22, 2023

📌 Commit4851cc9 has been approved byfmease

It is now in thequeue for this repository.

rustbot assignedfmease and unassignedjsha

Oct 22, 2023

bors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labels

Oct 22, 2023

Copy link

Collaborator

bors commentedOct 22, 2023

⌛ Testing commit4851cc9 with merge6aeac60...

Copy link

Collaborator

bors commentedOct 22, 2023

☀️ Test successful -checks-actions
Approved by: fmease
Pushing6aeac60 to master...

bors added the merged-by-borsThis PR was explicitly merged by bors. label

Oct 22, 2023

bors merged commit6aeac60 intorust-lang:master

Oct 22, 2023

rustbot added this to the1.75.0 milestone

Oct 22, 2023

notriddle deleted the notriddle/format-links-with-display branch

October 22, 2023 20:20

Copy link

Collaborator

rust-timer commentedOct 22, 2023

Finished benchmarking commit (6aeac60):comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.9%	[3.9%, 3.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	3.9%	[3.9%, 3.9%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.74s -> 629.056s (-0.42%)
Artifact size: 304.08 MiB -> 304.13 MiB (0.02%)

rustbot removed the perf-regressionPerformance regression. label

Oct 22, 2023

fmease removed the perf-regression-triagedThe performance regression has been triaged. label

Oct 23, 2023

fmease mentioned this pull request

Oct 26, 2023

Add adefault flag for enum documentation#115575

Closed

github-actionsbot mentioned this pull request

Oct 31, 2023

Automated pull from upstreammasterferrocene/ferrocene#74

Merged

bors-ferrocenebot added a commit to ferrocene/ferrocene that referenced this pull request

Oct 31, 2023

Merge#74

08731ee

74: Automated pull from upstream `master` r=tshepang a=github-actions[bot]This PR pulls the following changes from the upstream repository:*rust-lang/rust#117363*rust-lang/rust#116405*rust-lang/rust#117415  *rust-lang/rust#117414  *rust-lang/rust#117411  *rust-lang/rust#117403  *rust-lang/rust#117398  *rust-lang/rust#117396  *rust-lang/rust#117389  *rust-lang/rust#116862*rust-lang/rust#117405  *rust-lang/rust#117395  *rust-lang/rust#117390  *rust-lang/rust#117383  *rust-lang/rust#117376  *rust-lang/rust#117370  *rust-lang/rust#117357  *rust-lang/rust#117356  *rust-lang/rust#117317  *rust-lang/rust#117132  *rust-lang/rust#117068  *rust-lang/rust#112463*rust-lang/rust#117267*rust-lang/rust#116939*rust-lang/rust#117387  *rust-lang/rust#117385  *rust-lang/rust#117382  *rust-lang/rust#117371  *rust-lang/rust#117365  *rust-lang/rust#117350  *rust-lang/rust#117205  *rust-lang/rust#117177  *rust-lang/rust#117147*rust-lang/rust#116485*rust-lang/rust#117328*rust-lang/rust#117332*rust-lang/rust#117089*rust-lang/rust#116733*rust-lang/rust#116889*rust-lang/rust#116270*rust-lang/rust#117354  *rust-lang/rust#117337  *rust-lang/rust#117312  *rust-lang/rust#117082  *rust-lang/rust#117043  *rust-lang/rust#115968*rust-lang/rust#117336  *rust-lang/rust#117325  *rust-lang/rust#117322  *rust-lang/rust#117259  *rust-lang/rust#117170*rust-lang/rust#117335  *rust-lang/rust#117319  *rust-lang/rust#117316  *rust-lang/rust#117311  *rust-lang/rust#117162  *rust-lang/rust#115773*rust-lang/rust#116447*rust-lang/rust#117149*rust-lang/rust#116240*rust-lang/rust#117123*rust-lang/rust#81746*rust-lang/rust#117038*rust-lang/rust#116609*rust-lang/rust#117309  *rust-lang/rust#117277  *rust-lang/rust#117268  *rust-lang/rust#117256  *rust-lang/rust#117025  *rust-lang/rust#116945  *rust-lang/rust#116816  *rust-lang/rust#116739  *rust-lang/rust#116534*rust-lang/rust#117253*rust-lang/rust#117302*rust-lang/rust#117197*rust-lang/rust#116471*rust-lang/rust#117294  *rust-lang/rust#117287  *rust-lang/rust#117281  *rust-lang/rust#117270  *rust-lang/rust#117247  *rust-lang/rust#117246  *rust-lang/rust#117212  *rust-lang/rust#116834*rust-lang/rust#103208*rust-lang/rust#117166*rust-lang/rust#116751*rust-lang/rust#116858*rust-lang/rust#117272  *rust-lang/rust#117266  *rust-lang/rust#117262  *rust-lang/rust#117241  *rust-lang/rust#117240  *rust-lang/rust#116868  *rust-lang/rust#114998*rust-lang/rust#116205*rust-lang/rust#117260*rust-lang/rust#116035*rust-lang/rust#113183*rust-lang/rust#117249  *rust-lang/rust#117243  *rust-lang/rust#117188  *rust-lang/rust#117114  *rust-lang/rust#117106  *rust-lang/rust#117032  *rust-lang/rust#116968*rust-lang/rust#116581*rust-lang/rust#117228  *rust-lang/rust#117221  *rust-lang/rust#117214  *rust-lang/rust#117207  *rust-lang/rust#117202  *rust-lang/rust#117194  *rust-lang/rust#117143  *rust-lang/rust#117095  *rust-lang/rust#116905*rust-lang/rust#117171*rust-lang/rust#113262*rust-lang/rust#112875*rust-lang/rust#116983*rust-lang/rust#117148*rust-lang/rust#117115*rust-lang/rust#116818*rust-lang/rust#115872*rust-lang/rust#117193  *rust-lang/rust#117175  *rust-lang/rust#117009  *rust-lang/rust#117008  *rust-lang/rust#116931  *rust-lang/rust#116553  *rust-lang/rust#116401*rust-lang/rust#117180  *rust-lang/rust#117173  *rust-lang/rust#117163  *rust-lang/rust#117159  *rust-lang/rust#117154  *rust-lang/rust#117152  *rust-lang/rust#117141  *rust-lang/rust#117111*rust-lang/rust#117172  *rust-lang/rust#117168  *rust-lang/rust#117160  *rust-lang/rust#117158  *rust-lang/rust#117150  *rust-lang/rust#117136  *rust-lang/rust#117133  *rust-lang/rust#116801*rust-lang/rust#117165*rust-lang/rust#117113*rust-lang/rust#117102*rust-lang/rust#117076*rust-lang/rust#116236*rust-lang/rust#116993*rust-lang/rust#117139*rust-lang/rust#116482*rust-lang/rust#115796*rust-lang/rust#117135  *rust-lang/rust#117127  *rust-lang/rust#117010  *rust-lang/rust#116943  *rust-lang/rust#116841  *rust-lang/rust#116792  *rust-lang/rust#116714  *rust-lang/rust#116396  *rust-lang/rust#116094*rust-lang/rust#117126  *rust-lang/rust#117105  *rust-lang/rust#117093  *rust-lang/rust#117092  *rust-lang/rust#117091  *rust-lang/rust#117081*rust-lang/rust#116773*rust-lang/rust#117124*rust-lang/rust#116461*rust-lang/rust#116435*rust-lang/rust#116319*rust-lang/rust#116238*rust-lang/rust#116998*rust-lang/rust#116300*rust-lang/rust#117103  *rust-lang/rust#117086  *rust-lang/rust#117074  *rust-lang/rust#117070  *rust-lang/rust#117046  *rust-lang/rust#116859  *rust-lang/rust#107159*rust-lang/rust#116033*rust-lang/rust#107009*rust-lang/rust#117087  *rust-lang/rust#117073  *rust-lang/rust#117064  *rust-lang/rust#117040  *rust-lang/rust#116978  *rust-lang/rust#116960*rust-lang/rust#116837*rust-lang/rust#116835*rust-lang/rust#116849*rust-lang/rust#117071  *rust-lang/rust#117069  *rust-lang/rust#117051  *rust-lang/rust#117049  *rust-lang/rust#117044  *rust-lang/rust#117042  *rust-lang/rust#105666*rust-lang/rust#116606*rust-lang/rust#117066*rust-lang/rust#115324*rust-lang/rust#117062*rust-lang/rust#117000*rust-lang/rust#117007*rust-lang/rust#117018*rust-lang/rust#116256*rust-lang/rust#117041  *rust-lang/rust#117037  *rust-lang/rust#117034  *rust-lang/rust#116989  *rust-lang/rust#116985*rust-lang/rust#116950*rust-lang/rust#116956*rust-lang/rust#116932*rust-lang/rust#117031*rust-lang/rust#117030  *rust-lang/rust#117028  *rust-lang/rust#117026  *rust-lang/rust#116992  *rust-lang/rust#116981  *rust-lang/rust#116955  *rust-lang/rust#116928  *rust-lang/rust#116312*rust-lang/rust#116368*rust-lang/rust#116922*rust-lang/rust#117021*rust-lang/rust#117020  *rust-lang/rust#117019  *rust-lang/rust#116975  *rust-lang/rust#106601*rust-lang/rust#116734*rust-lang/rust#117013  *rust-lang/rust#116995  *rust-lang/rust#116990  *rust-lang/rust#116974  *rust-lang/rust#116964  *rust-lang/rust#116961  *rust-lang/rust#116917  *rust-lang/rust#116911  *rust-lang/rust#114521*rust-lang/rust#117011*rust-lang/rust#116958*rust-lang/rust#116951*rust-lang/rust#116966*rust-lang/rust#116965*rust-lang/rust#116962*rust-lang/rust#116946*rust-lang/rust#116899*rust-lang/rust#116785*rust-lang/rust#116838*rust-lang/rust#116875*rust-lang/rust#116874*rust-lang/rust#115214*rust-lang/rust#116810*rust-lang/rust#116940  *rust-lang/rust#116921  *rust-lang/rust#116906  *rust-lang/rust#116896  *rust-lang/rust#116650*rust-lang/rust#116132*rust-lang/rust#116037*rust-lang/rust#116923  *rust-lang/rust#116912  *rust-lang/rust#116908  *rust-lang/rust#116883  *rust-lang/rust#116829  *rust-lang/rust#116795  *rust-lang/rust#116761  *rust-lang/rust#116663*rust-lang/rust#114534*rust-lang/rust#116402*rust-lang/rust#116493*rust-lang/rust#116046*rust-lang/rust#116887*rust-lang/rust#116885  *rust-lang/rust#116879  *rust-lang/rust#116870  *rust-lang/rust#116865  *rust-lang/rust#116856  *rust-lang/rust#116812*rust-lang/rust#116815*rust-lang/rust#116814*rust-lang/rust#116713*rust-lang/rust#116830Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>Co-authored-by: antoyo <antoyo@users.noreply.github.com>Co-authored-by: Antoni Boucher <bouanto@zoho.com>Co-authored-by: bors <bors@rust-lang.org>Co-authored-by: Esteban Küber <esteban@kuber.com.ar>Co-authored-by: Kjetil Kjeka <kjetilkjeka@gmail.com>Co-authored-by: clubby789 <jamie@hill-daniel.co.uk>Co-authored-by: okaneco <47607823+okaneco@users.noreply.github.com>Co-authored-by: David Tolnay <dtolnay@gmail.com>Co-authored-by: Nadrieril <nadrieril+git@gmail.com>Co-authored-by: Celina G. Val <celinval@amazon.com>Co-authored-by: Ralf Jung <post@ralfj.de>Co-authored-by: Zalathar <Zalathar@users.noreply.github.com>Co-authored-by: Havard Eidnes <he@NetBSD.org>Co-authored-by: Jacob Pratt <jacob@jhpratt.dev>Co-authored-by: Kjetil Kjeka <kjetil@muybridge.com>

bors-ferrocenebot added a commit to ferrocene/ferrocene that referenced this pull request

Oct 31, 2023

Merge#74

e4e629c

74: Automated pull from upstream `master` r=tshepang a=github-actions[bot]This PR pulls the following changes from the upstream repository:*rust-lang/rust#117363*rust-lang/rust#116405*rust-lang/rust#117415  *rust-lang/rust#117414  *rust-lang/rust#117411  *rust-lang/rust#117403  *rust-lang/rust#117398  *rust-lang/rust#117396  *rust-lang/rust#117389  *rust-lang/rust#116862*rust-lang/rust#117405  *rust-lang/rust#117395  *rust-lang/rust#117390  *rust-lang/rust#117383  *rust-lang/rust#117376  *rust-lang/rust#117370  *rust-lang/rust#117357  *rust-lang/rust#117356  *rust-lang/rust#117317  *rust-lang/rust#117132  *rust-lang/rust#117068  *rust-lang/rust#112463*rust-lang/rust#117267*rust-lang/rust#116939*rust-lang/rust#117387  *rust-lang/rust#117385  *rust-lang/rust#117382  *rust-lang/rust#117371  *rust-lang/rust#117365  *rust-lang/rust#117350  *rust-lang/rust#117205  *rust-lang/rust#117177  *rust-lang/rust#117147*rust-lang/rust#116485*rust-lang/rust#117328*rust-lang/rust#117332*rust-lang/rust#117089*rust-lang/rust#116733*rust-lang/rust#116889*rust-lang/rust#116270*rust-lang/rust#117354  *rust-lang/rust#117337  *rust-lang/rust#117312  *rust-lang/rust#117082  *rust-lang/rust#117043  *rust-lang/rust#115968*rust-lang/rust#117336  *rust-lang/rust#117325  *rust-lang/rust#117322  *rust-lang/rust#117259  *rust-lang/rust#117170*rust-lang/rust#117335  *rust-lang/rust#117319  *rust-lang/rust#117316  *rust-lang/rust#117311  *rust-lang/rust#117162  *rust-lang/rust#115773*rust-lang/rust#116447*rust-lang/rust#117149*rust-lang/rust#116240*rust-lang/rust#117123*rust-lang/rust#81746*rust-lang/rust#117038*rust-lang/rust#116609*rust-lang/rust#117309  *rust-lang/rust#117277  *rust-lang/rust#117268  *rust-lang/rust#117256  *rust-lang/rust#117025  *rust-lang/rust#116945  *rust-lang/rust#116816  *rust-lang/rust#116739  *rust-lang/rust#116534*rust-lang/rust#117253*rust-lang/rust#117302*rust-lang/rust#117197*rust-lang/rust#116471*rust-lang/rust#117294  *rust-lang/rust#117287  *rust-lang/rust#117281  *rust-lang/rust#117270  *rust-lang/rust#117247  *rust-lang/rust#117246  *rust-lang/rust#117212  *rust-lang/rust#116834*rust-lang/rust#103208*rust-lang/rust#117166*rust-lang/rust#116751*rust-lang/rust#116858*rust-lang/rust#117272  *rust-lang/rust#117266  *rust-lang/rust#117262  *rust-lang/rust#117241  *rust-lang/rust#117240  *rust-lang/rust#116868  *rust-lang/rust#114998*rust-lang/rust#116205*rust-lang/rust#117260*rust-lang/rust#116035*rust-lang/rust#113183*rust-lang/rust#117249  *rust-lang/rust#117243  *rust-lang/rust#117188  *rust-lang/rust#117114  *rust-lang/rust#117106  *rust-lang/rust#117032  *rust-lang/rust#116968*rust-lang/rust#116581*rust-lang/rust#117228  *rust-lang/rust#117221  *rust-lang/rust#117214  *rust-lang/rust#117207  *rust-lang/rust#117202  *rust-lang/rust#117194  *rust-lang/rust#117143  *rust-lang/rust#117095  *rust-lang/rust#116905*rust-lang/rust#117171*rust-lang/rust#113262*rust-lang/rust#112875*rust-lang/rust#116983*rust-lang/rust#117148*rust-lang/rust#117115*rust-lang/rust#116818*rust-lang/rust#115872*rust-lang/rust#117193  *rust-lang/rust#117175  *rust-lang/rust#117009  *rust-lang/rust#117008  *rust-lang/rust#116931  *rust-lang/rust#116553  *rust-lang/rust#116401*rust-lang/rust#117180  *rust-lang/rust#117173  *rust-lang/rust#117163  *rust-lang/rust#117159  *rust-lang/rust#117154  *rust-lang/rust#117152  *rust-lang/rust#117141  *rust-lang/rust#117111*rust-lang/rust#117172  *rust-lang/rust#117168  *rust-lang/rust#117160  *rust-lang/rust#117158  *rust-lang/rust#117150  *rust-lang/rust#117136  *rust-lang/rust#117133  *rust-lang/rust#116801*rust-lang/rust#117165*rust-lang/rust#117113*rust-lang/rust#117102*rust-lang/rust#117076*rust-lang/rust#116236*rust-lang/rust#116993*rust-lang/rust#117139*rust-lang/rust#116482*rust-lang/rust#115796*rust-lang/rust#117135  *rust-lang/rust#117127  *rust-lang/rust#117010  *rust-lang/rust#116943  *rust-lang/rust#116841  *rust-lang/rust#116792  *rust-lang/rust#116714  *rust-lang/rust#116396  *rust-lang/rust#116094*rust-lang/rust#117126  *rust-lang/rust#117105  *rust-lang/rust#117093  *rust-lang/rust#117092  *rust-lang/rust#117091  *rust-lang/rust#117081*rust-lang/rust#116773*rust-lang/rust#117124*rust-lang/rust#116461*rust-lang/rust#116435*rust-lang/rust#116319*rust-lang/rust#116238*rust-lang/rust#116998*rust-lang/rust#116300*rust-lang/rust#117103  *rust-lang/rust#117086  *rust-lang/rust#117074  *rust-lang/rust#117070  *rust-lang/rust#117046  *rust-lang/rust#116859  *rust-lang/rust#107159*rust-lang/rust#116033*rust-lang/rust#107009*rust-lang/rust#117087  *rust-lang/rust#117073  *rust-lang/rust#117064  *rust-lang/rust#117040  *rust-lang/rust#116978  *rust-lang/rust#116960*rust-lang/rust#116837*rust-lang/rust#116835*rust-lang/rust#116849*rust-lang/rust#117071  *rust-lang/rust#117069  *rust-lang/rust#117051  *rust-lang/rust#117049  *rust-lang/rust#117044  *rust-lang/rust#117042  *rust-lang/rust#105666*rust-lang/rust#116606*rust-lang/rust#117066*rust-lang/rust#115324*rust-lang/rust#117062*rust-lang/rust#117000*rust-lang/rust#117007*rust-lang/rust#117018*rust-lang/rust#116256*rust-lang/rust#117041  *rust-lang/rust#117037  *rust-lang/rust#117034  *rust-lang/rust#116989  *rust-lang/rust#116985*rust-lang/rust#116950*rust-lang/rust#116956*rust-lang/rust#116932*rust-lang/rust#117031*rust-lang/rust#117030  *rust-lang/rust#117028  *rust-lang/rust#117026  *rust-lang/rust#116992  *rust-lang/rust#116981  *rust-lang/rust#116955  *rust-lang/rust#116928  *rust-lang/rust#116312*rust-lang/rust#116368*rust-lang/rust#116922*rust-lang/rust#117021*rust-lang/rust#117020  *rust-lang/rust#117019  *rust-lang/rust#116975  *rust-lang/rust#106601*rust-lang/rust#116734*rust-lang/rust#117013  *rust-lang/rust#116995  *rust-lang/rust#116990  *rust-lang/rust#116974  *rust-lang/rust#116964  *rust-lang/rust#116961  *rust-lang/rust#116917  *rust-lang/rust#116911  *rust-lang/rust#114521*rust-lang/rust#117011*rust-lang/rust#116958*rust-lang/rust#116951*rust-lang/rust#116966*rust-lang/rust#116965*rust-lang/rust#116962*rust-lang/rust#116946*rust-lang/rust#116899*rust-lang/rust#116785*rust-lang/rust#116838*rust-lang/rust#116875*rust-lang/rust#116874*rust-lang/rust#115214*rust-lang/rust#116810*rust-lang/rust#116940  *rust-lang/rust#116921  *rust-lang/rust#116906  *rust-lang/rust#116896  *rust-lang/rust#116650*rust-lang/rust#116132*rust-lang/rust#116037*rust-lang/rust#116923  *rust-lang/rust#116912  *rust-lang/rust#116908  *rust-lang/rust#116883  *rust-lang/rust#116829  *rust-lang/rust#116795  *rust-lang/rust#116761  *rust-lang/rust#116663*rust-lang/rust#114534*rust-lang/rust#116402*rust-lang/rust#116493*rust-lang/rust#116046*rust-lang/rust#116887*rust-lang/rust#116885  *rust-lang/rust#116879  *rust-lang/rust#116870  *rust-lang/rust#116865  *rust-lang/rust#116856  *rust-lang/rust#116812*rust-lang/rust#116815*rust-lang/rust#116814*rust-lang/rust#116713*rust-lang/rust#116830Co-authored-by: antoyo <antoyo@users.noreply.github.com>Co-authored-by: Antoni Boucher <bouanto@zoho.com>Co-authored-by: bors <bors@rust-lang.org>Co-authored-by: Esteban Küber <esteban@kuber.com.ar>Co-authored-by: Kjetil Kjeka <kjetilkjeka@gmail.com>Co-authored-by: clubby789 <jamie@hill-daniel.co.uk>Co-authored-by: okaneco <47607823+okaneco@users.noreply.github.com>Co-authored-by: David Tolnay <dtolnay@gmail.com>Co-authored-by: Nadrieril <nadrieril+git@gmail.com>Co-authored-by: Celina G. Val <celinval@amazon.com>Co-authored-by: Ralf Jung <post@ralfj.de>Co-authored-by: Zalathar <Zalathar@users.noreply.github.com>Co-authored-by: Havard Eidnes <he@NetBSD.org>Co-authored-by: Jacob Pratt <jacob@jhpratt.dev>Co-authored-by: Kjetil Kjeka <kjetil@muybridge.com>Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>