- Notifications
You must be signed in to change notification settings - Fork13.9k
Remove some stale FIXMEs in new solver#109580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
| goal:Goal<'tcx,SubtypePredicate<'tcx>>, | ||
| ) ->QueryResult<'tcx>{ | ||
| if goal.predicate.a.is_ty_var() && goal.predicate.b.is_ty_var(){ | ||
| // FIXME: Do we want to register a subtype relation between these vars? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this makes no sense lol
| //! FIXME(@lcnr): Write that section. If you read this before then ask me | ||
| //! about it on zulip. | ||
| // FIXME: uses of `infcx.at` need to enable deferred projection equality once that's implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We already do this :)
| tcx:TyCtxt<'tcx>, | ||
| goal:CanonicalGoal<'tcx>, | ||
| ) ->Result<(),QueryResult<'tcx>>{ | ||
| // FIXME: start by checking the global cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We check the global cache in the parent caller
…iaskrgrRollup of 7 pull requestsSuccessful merges: -rust-lang#108625 (More config.toml.example cleanups) -rust-lang#109418 (Rename 'src/bootstrap/native.rs' to llvm.rs) -rust-lang#109580 (Remove some stale FIXMEs in new solver) -rust-lang#109582 (Refactor: Separate `LocalRef` variant for not-evaluated-yet operands) -rust-lang#109650 (Remove Nilstrieb from review rotation) -rust-lang#109656 (Update cargo) -rust-lang#109658 (Backport 1.68.1 and 1.68.2 release notes to `master`)Failed merges:r? `@ghost``@rustbot` modify labels: rollup
Some FIXMEs are no longer needed