Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove unnecessary raw pointer in __rust_start_panic arg#102742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bors merged 1 commit intorust-lang:masterfrombjorn3:cleanup_rust_start_panic
Mar 27, 2023

Conversation

@bjorn3
Copy link
Member

It is no longer necessary as __rust_start_panic switched to the Rust abi.

@bjorn3bjorn3 added the C-cleanupCategory: PRs that clean code up or issues documenting cleanup. labelOct 6, 2022
@rustbotrustbot added the T-libsRelevant to the library team, which will review and decide on the PR/issue. labelOct 6, 2022
@rustbot
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to anyrust-lang/rust public library APIs then please comment with@rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevantAPI Change Proposal orcreate one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples ofT-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r?@joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelOct 6, 2022
@bjorn3bjorn3force-pushed thecleanup_rust_start_panic branch froma9a6545 to1ae0129CompareOctober 6, 2022 16:51
@bjorn3
Copy link
MemberAuthor

Miri usesmiri_start_panic as unwind entrypoint, which is called by panic_unwind's__rust_start_panic, so no miri changes needed afaict.

RalfJung reacted with thumbs up emoji

@Aaron1011
Copy link
Contributor

For reference, my previous comment was "I think this will require changes to Miri". I deleted it shortly after posting it, as I realized it was incorrect :)

bjorn3 reacted with thumbs up emoji

@ChrisDenton
Copy link
Member

This looks like a nice improvement. Maybe squish the commits though?

It is no longer necessary as __rust_start_panic switched to the Rust abi.
@bjorn3bjorn3force-pushed thecleanup_rust_start_panic branch fromf932b91 tob874502CompareMarch 26, 2023 16:41
@bjorn3
Copy link
MemberAuthor

Rebased and squashed.

@ChrisDenton
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

📌 Commitb874502 has been approved byChrisDenton

It is now in thequeue for this repository.

@bors
Copy link
Collaborator

🌲 The tree is currentlyclosed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties. labelsMar 26, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull requestMar 27, 2023
…iaskrgrRollup of 8 pull requestsSuccessful merges: -rust-lang#97506 (Stabilize `nonnull_slice_from_raw_parts`) -rust-lang#98651 (Follow C-RW-VALUE in std::io::Cursor example) -rust-lang#102742 (Remove unnecessary raw pointer in __rust_start_panic arg) -rust-lang#109587 (Use an IndexVec to debug fingerprints.) -rust-lang#109613 (fix type suggestions in match arms) -rust-lang#109633 (Fix "Directly go to item in search if there is only one result" setting) -rust-lang#109635 (debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of) -rust-lang#109641 (Don't elaborate non-obligations into obligations)Failed merges:r? `@ghost``@rustbot` modify labels: rollup
@borsbors merged commit704991c intorust-lang:masterMar 27, 2023
@rustbotrustbot added this to the1.70.0 milestoneMar 27, 2023
@bjorn3bjorn3 deleted the cleanup_rust_start_panic branchMarch 27, 2023 13:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments

+1 more reviewer

@BlackHoleFoxBlackHoleFoxBlackHoleFox left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joshtriplettjoshtriplett

Labels

C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.70.0

Development

Successfully merging this pull request may close these issues.

9 participants

@bjorn3@rustbot@rust-highfive@Aaron1011@ChrisDenton@bors@RalfJung@BlackHoleFox@joshtriplett

[8]ページ先頭

©2009-2025 Movatter.jp