- Notifications
You must be signed in to change notification settings - Fork180
upgrade zlib-rs to version0.5.1#490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot!
ac4d950 intorust-lang:mainUh oh!
There was an error while loading.Please reload this page.
| @@ -468,7 +468,7 @@ mod c_backend { | |||
| #[cfg(feature ="zlib-ng")] | |||
| constZLIB_VERSION:&str ="2.1.0.devel\0"; | |||
| #[cfg(all(not(feature ="zlib-ng"), feature ="zlib-rs"))] | |||
| constZLIB_VERSION:&str ="1.3.0-zlib-rs-0.5.0\0"; | |||
| constZLIB_VERSION:&str ="1.3.0-zlib-rs-0.5.1\0"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I just realised that if it wasn't for this string,flate2 wouldn't need a release ifzlib-rs increases its patch level.
Something I am wondering about is if this lock-step releasing is truly required for everything to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As far as I can tell, the only thing thatzlib-rs actually cares about is thatthe first byte of the string is a '1' character.
A new release is now available:https://github.com/rust-lang/flate2-rs/releases/tag/1.1.2 |
https://github.com/trifectatechfoundation/zlib-rs/releases/tag/v0.5.1
Fixes some minor bugs and improves performance.